docs: the keyword is docs, not doc #2502
Conversation
daviddias
force-pushed
the
docs-docs-docs
branch
from
65cee0e
to
9d3b1e7
Compare
|
I have no strong opinion on |
|
The longer we wait, the more links to |
|
Not sure a redirect README would help, if people follow a link to https://github.com/ipfs/js-ipfs/blob/master/doc/EARLY_TESTERS.md they'll see the GH 404 page, not the README. |
|
Ah right! Ouch.. well, if it stays |
|
I don't really have strong feels on this but if most people are expecting "docs" then lets use it. Also, if it'll make @daviddias happy then it's definitely worth it. It'll be consistent with the go-ipfs directory name as well as our commit message prefix for documentation changes ( Lets get this moved, shall we leave stub files in TODO: We also need to update aegir release scripts to add @daviddias do you have a sec to fix up this PR? |
I'd say no - it's been a couple of weeks, no new early testers have surfaced for a little while so let's just rename it (once the change to aegir has been made). |
Caaaaaan doooo |
daviddias
force-pushed
the
docs-docs-docs
branch
from
9d3b1e7
to
0ee3f27
Compare
Didn't we need a PR to aegir before this was merged? |
These are not used and get put into the `docs` directory which is no longer ignored so we end up with a dirty repo on release. refs #2502 (comment) License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
These are not used and get put into the `docs` directory which is no longer ignored so we end up with a dirty repo on release. refs #2502 (comment) License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
The usage of
docrather thandocshas been making me twitch every time I see it. It is a nitpick for the sake of consistency everywhere :)Update: and now I know why it was selected
docoverdocs, because there was a .gitignore fordocsbecause of the long gone effort to document everything with documentation.js