Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

test: add repo-stat tests #2592

Closed
wants to merge 7 commits into from
Closed

Conversation

PedroMiguelSS
Copy link
Contributor

@PedroMiguelSS PedroMiguelSS commented Nov 7, 2019

Add tests for repo-stat() and make the cli output consistent with go-ipfs.

⚠️Related PRs that need to be merged and released before this one can be:

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you make the commit line test: please. Turns out not everything is a chore, eh @alanshaw ?

See the commit types in ipfs/community/CONTRIBUTING_JS.md for more.

test/cli/repo.js Outdated Show resolved Hide resolved
@PedroMiguelSS PedroMiguelSS force-pushed the chore/add-repo-stat-tests branch from 0b364e0 to 24d7de6 Compare November 7, 2019 18:10
@PedroMiguelSS PedroMiguelSS changed the title chore: add repo-stat tests test: add repo-stat tests Nov 7, 2019
@PedroMiguelSS
Copy link
Contributor Author

@achingbrain commit line changed 👍

@PedroMiguelSS PedroMiguelSS force-pushed the chore/add-repo-stat-tests branch from 9a5a871 to 6b06e0e Compare November 14, 2019 11:24
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there. So nearly there!

test/cli/repo.js Outdated Show resolved Hide resolved
test/cli/repo.js Outdated Show resolved Hide resolved
test/cli/repo.js Outdated Show resolved Hide resolved
test/cli/repo.js Show resolved Hide resolved
@PedroMiguelSS PedroMiguelSS force-pushed the chore/add-repo-stat-tests branch from 139080b to e7514de Compare November 19, 2019 11:54
@PedroMiguelSS PedroMiguelSS deleted the chore/add-repo-stat-tests branch November 25, 2019 12:04
@PedroMiguelSS
Copy link
Contributor Author

Closed in favor of #2630.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants