Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

docs: updated examples to new api #2729

Merged
merged 56 commits into from
Feb 3, 2020
Merged

docs: updated examples to new api #2729

merged 56 commits into from
Feb 3, 2020

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Jan 24, 2020

BREAKING CHANGE:

Where PeerIDs were previously CIDs, now they are Strings

  • ipfs.bitswap.stat().peers[n] is now a String (was a CID)
  • ipfs.dht.findPeer().id is now a String (was a CID)
  • ipfs.dht.findProvs()[n].id is now a String (was a CID)
  • ipfs.dht.provide()[n].id is now a String (was a CID)
  • ipfs.dht.put()[n].id is now a String (was a CID)
  • ipfs.dht.query()[n].id is now a String (was a CID)
  • ipfs.id().id is now a String (was a CID)
  • ipfs.id().addresses[n] are now Multiaddrs (were Strings)

Depends on:

@alanshaw
Copy link
Member

Please add BREAKING CHANGE message.

@alanshaw alanshaw mentioned this pull request Jan 31, 2020
57 tasks
examples/browser-video-streaming/index.html Outdated Show resolved Hide resolved
examples/browser-video-streaming/streaming.js Outdated Show resolved Hide resolved
examples/exchange-files-in-browser/public/app.js Outdated Show resolved Hide resolved
test/core/interface.spec.js Outdated Show resolved Hide resolved
test/utils/factory.js Outdated Show resolved Hide resolved
achingbrain and others added 4 commits January 31, 2020 12:59
Co-Authored-By: Alan Shaw <alan.shaw@protocol.ai>
How did this ever work?

Co-Authored-By: Alan Shaw <alan.shaw@protocol.ai>
How did this ever work?

Co-Authored-By: Alan Shaw <alan.shaw@protocol.ai>
@achingbrain achingbrain force-pushed the refactor/async-examples branch from e6ce386 to 2671356 Compare January 31, 2020 13:12
@alanshaw alanshaw mentioned this pull request Jan 31, 2020
@achingbrain achingbrain mentioned this pull request Feb 3, 2020
1 task
@alanshaw alanshaw merged commit 16d540c into master Feb 3, 2020
@alanshaw alanshaw deleted the refactor/async-examples branch February 3, 2020 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants