This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
update deps #283
Merged
update deps #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dignifiedquire still same bug. It is because browser nodes are getting websockets addr, which they shouldn't. This also should not be a issue cause the transport for websockets is just added after the listen, but this errors comes with the fact that you goOnline and goOffline several times. See: https://github.com/ipfs/js-libp2p-ipfs-browser/blob/master/src/index.js#L36-L44 Adding ws multiaddrs to browser nodes is confusing, it already misguided @haadcode twice and will mislead our users (remember that those websockets addrs get transferred through identify). Would you mind if we change that from the tests? |
No, just make sure they are added when running in node where we need them |
daviddias
force-pushed
the
update-deps2
branch
3 times, most recently
from
1fdc93a
to
a2529fb
Compare
This was referenced Jul 31, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.