Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: turn on delegate nodes by default #3148

Merged
merged 3 commits into from
Jul 10, 2020

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Jul 7, 2020

To help find content and peers on the network, turn on delegate nodes by default.

Disables delegate nodes while using the test config profile.

To help find content and peers on the network, turn on delegate
nodes by default on node.js only.
@achingbrain
Copy link
Member Author

I'd like some thoughts on this - it'll help with peers and DHT queries, but provides will only work for an hour or so (until GC runs on the delegate node).

Does GC clear up DHT records from the datastore?

Do we need some way of perhaps not doing the provide so we can get the findpeer and findprovs goodness without making content harder to resolve?

@vasco-santos
Copy link
Member

vasco-santos commented Jul 9, 2020

I was thinking earlier today, if a go-ipfs node acting as a delegated router would run the reprovider for the records it received. I am not sure

So, in js-ipfs we will need the reprovider with the DHT for what you just described. But, using a third party node DHT, would be the responsibility of this third party node to reprovide? or would it be the peer who asked for it?

Reprovider docs: https://github.com/ipfs/go-ipfs/blob/b86e93045aaa0ac357d939884e1c7996b0fcdbd4/docs/config.md#reprovider

@achingbrain achingbrain changed the title fix: turn on delegate nodes by default feat: turn on delegate nodes by default Jul 10, 2020
@achingbrain achingbrain merged commit 3fd2ca8 into master Jul 10, 2020
@achingbrain achingbrain deleted the fix/enable-delegate-nodes-by-default branch July 10, 2020 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants