This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: shared node demo #3203
Merged
fix: shared node demo #3203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like CI is still has not run tests for this example, I'm not sure why 🤷♂️ |
achingbrain
approved these changes
Aug 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared worker example stopped working, and we have not noticed because for some reason CI doesn't seem to run it. There were several problems:
ipfs.addAPI.add/addAll, I have regressed the example 2302b2f#diff-48144c5d1809a34109f2559846446f22R21. Have not noticed that, because CI doesn't seem to run it.CopyWebpackPluginwhich then I thought was unnecessary and removed. Howeverindex.htmlwas placed indistfrom prior runs so after change tests were still passing (and CI never seemed to have run this example).This pull addresses all of those problems so that example passes tests. I'm still not sure why CI isn't executing this, test but we can figure out in the separate pull.