Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: prioritize noise over secio #3216

Merged
merged 1 commit into from
Aug 10, 2020
Merged

feat: prioritize noise over secio #3216

merged 1 commit into from
Aug 10, 2020

Conversation

jacobheun
Copy link
Contributor

This would be good to land in 0.49 as we're planning to remove support for SECIO in 0.50.

  • When dialing js-ipfs >=0.47, or go-ipfs >=0.5 nodes, there will be no latency hit as we can start Noise immediately.
  • Incoming dials for ipfs <0.49 and >0=0.47, will take a round trip hit when connecting as they'll fail to negotiate Secio and fallback to Noise

@jacobheun jacobheun requested a review from achingbrain August 7, 2020 17:48
@achingbrain achingbrain merged commit f3a67c4 into master Aug 10, 2020
@achingbrain achingbrain deleted the feat/noise-over-secio branch August 10, 2020 12:32
@github-actions github-actions bot mentioned this pull request Jan 25, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DONALDSULLENDER DONALDSULLENDER DONALDSULLENDER approved these changes

@achingbrain achingbrain achingbrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobheun @achingbrain @DONALDSULLENDER