Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: webui v2.11.4 #3317

Merged
merged 2 commits into from
Oct 15, 2020
Merged

feat: webui v2.11.4 #3317

merged 2 commits into from
Oct 15, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Oct 6, 2020

https://github.com/ipfs-shipyard/ipfs-webui/releases/tag/v2.11.3
https://github.com/ipfs-shipyard/ipfs-webui/releases/tag/v2.11.4

Sadly #2580 broke E2E tests: we don't see if changing this hash broke anything until we release ipfs-http-server and bump it in ipfs

  • manual test (swapped hash in js-ipfs sources of v0.50.2 and looks good)
  • figure out how to run webui's e2e tests

@lidel lidel changed the title feat: webui v2.11.3 feat: webui v2.11.4 Oct 7, 2020
@achingbrain
Copy link
Member

Can you run E2E tests against the RCs?

@lidel
Copy link
Member Author

lidel commented Oct 7, 2020

Ah, yes, I see the CI end-to-end tests from webui's master against ipfs@next package:

js-ipfs/.travis.yml

Lines 260 to 265 in 8e44e52

- stage: test-external
# only run on changes to master
if: branch = master AND type = push AND fork = false
name: external - ipfs-webui
script:
- E2E_IPFSD_TYPE=js npm run test:external -- -- -- https://github.com/ipfs-shipyard/ipfs-webui.git --deps=ipfs@next

Nvm then, this should be good enough.

@lidel lidel requested a review from achingbrain October 7, 2020 15:52
@lidel lidel marked this pull request as ready for review October 7, 2020 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants