This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: make message-port-protocol non dev dependency #3393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
approved these changes
Nov 13, 2020
achingbrain
added a commit
to ipfs/aegir
that referenced
this pull request
Nov 13, 2020
Adds a convenience flag to only check for missing production deps. Also fixes the spinner when dep-checks fail so the formatting of the error message isn't all kinds of messed up. Would have caught ipfs/js-ipfs#3393
achingbrain
added a commit
to ipfs/aegir
that referenced
this pull request
Nov 13, 2020
Adds a convenience flag to only check for missing production deps. Also allows the user to pass files to check instead of always using the defaults. Also, also fixes the spinner when dep-checks fail so the formatting of the error message isn't all kinds of messed up. Would have caught ipfs/js-ipfs#3393
achingbrain
added a commit
to ipfs/aegir
that referenced
this pull request
Nov 13, 2020
Adds a convenience flag to only check for missing production deps. Also allows the user to pass files to check instead of always using the defaults. Also, also fixes the spinner when dep-checks fail so the formatting of the error message isn't all kinds of messed up. Would have caught ipfs/js-ipfs#3393
achingbrain
added a commit
to ipfs/aegir
that referenced
this pull request
Nov 16, 2020
Adds a convenience flag to only check for missing production deps. Also fixes the spinner when dep-checks fail so the formatting of the error message isn't all kinds of messed up. Also, also adds `--ignore` options to the dep check so we can pass options to aegir and to the underlying dependency-check binary. Would have caught ipfs/js-ipfs#3393
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix message-port-client/server packages by declaring message-port-protocol as dependency that it is, instead of devDependency.