Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: Add pin.add to ipfs-message-port #3497

Closed
wants to merge 3 commits into from

Conversation

icidasset
Copy link
Contributor

Adds pin.add to ipfs-message-port-client and ipfs-message-port-server.

@achingbrain
Copy link
Member

Looks good as a first pass, thanks for submitting this.

Can you please add the ipfs.pin.add interface test suite to /packages/ipfs-message-port-client/test/interface-message-port-client.js to ensure this gets tested in CI etc.

@achingbrain
Copy link
Member

By way of an example, see how the pinning tests are run for testing the http client against go-IPFS - nb. you'll need to add skips for the parts of the pinning API that haven't been implemented in this PR.

@icidasset
Copy link
Contributor Author

@achingbrain Done. I did have to skip all the tests because pin.ls is not implemented. Might look into that later if I have some time and if it's not too difficult.

@Gozala
Copy link
Contributor

Gozala commented Feb 18, 2021

@achingbrain Done. I did have to skip all the tests because pin.ls is not implemented. Might look into that later if I have some time and if it's not too difficult.

@icidasset This looks good, but I think we would need to add pin.ls (even if just limited version and only for testing) otherwise things may not work or break and we won't even know that.

P.S.: Bunch of APIs here were actually implemented just to enable testing not because they were intentionally included.

@icidasset
Copy link
Contributor Author

@Gozala I've added pin.ls and pin.rmAll. Most of the tests are passing, but there's a few that are still failing that I can't seem to get fixed. Could you take a look?

There's one metadata issue with pin.ls that's weird, I should be passing the metadata along from with result. And another issue with normaliseInput and pin.rmAll, for some reason it's not able to decode some CIDs.

@Gozala
Copy link
Contributor

Gozala commented Feb 27, 2021

@Gozala I've added pin.ls and pin.rmAll. Most of the tests are passing, but there's a few that are still failing that I can't seem to get fixed. Could you take a look?

There's one metadata issue with pin.ls that's weird, I should be passing the metadata along from with result. And another issue with normaliseInput and pin.rmAll, for some reason it's not able to decode some CIDs.

Thanks for championing this effort! I've resolved remaining issues in #3575

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants