-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Add pin.add to ipfs-message-port #3497
Conversation
Looks good as a first pass, thanks for submitting this. Can you please add the |
By way of an example, see how the pinning tests are run for testing the http client against go-IPFS - nb. you'll need to add skips for the parts of the pinning API that haven't been implemented in this PR. |
@achingbrain Done. I did have to skip all the tests because |
@icidasset This looks good, but I think we would need to add P.S.: Bunch of APIs here were actually implemented just to enable testing not because they were intentionally included. |
65f13ba
to
43f9dea
Compare
43f9dea
to
dd8fa53
Compare
@Gozala I've added There's one metadata issue with |
Thanks for championing this effort! I've resolved remaining issues in #3575 |
Adds
pin.add
toipfs-message-port-client
andipfs-message-port-server
.