This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: loosen input type for swarm.connect and swarm.disconnect #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept peer ids as strings or multiaddrs as Multiaddrs. Fixes #3638
This was referenced Mar 21, 2022
This was referenced Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept peer ids as strings or multiaddrs as Multiaddrs.
Also removes accepting peerIDs as CIDs for consistency as I don't think we actually return peerIDs as CIDs from the api anywhere (from
ipfs.swarm.peers, for example), only ever as strings.Fixes #3638