-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: only accept cid for ipfs.dag.get #3675
Conversation
If you have a path within the DAG to resolve, pass it as `path` in the options object as per the documentation. Fixes #3637
Travis is failing because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is intentional - the idea is to show a single idea as simply as possible and to not make any other technical decisions for the user, e.g. just plain js as far as possible, as they'll likely copy/paste example code into their own app so we don't want them to then have to remove extra scaffolding or framework code etc. |
I do not see, why we need to restrict the types. Because most js-IPFS functions (see Files API) |
If you have a path within the DAG to resolve, pass it as
path
in the options object.Makes the API conform to the documentation.
Fixes #3637