This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: remove optional chaining from code that will be transpiled #3698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional chaining is supported in node and in browsers but tools that transpile code to run in older browsers doesn't understand the syntax. Specifically the version of acorn that at least vue uses via a dependency on webpack 4 does not support this. It'll be fixed by them upgrading to webpack 5 but the timescale on that is unclear, which is why we're using a prerelease version in our examples. The short term fix is to just remove optional chaining from where we are using it in code that will be transpiled for browser use.
…-chaining-from-code-that-will-be-transpiled
lidel
approved these changes
May 25, 2021
There was a problem hiding this comment.
👍 for short term fix, but this type of thing often comes back as new PRs get merged.
Should we enforce https://eslint.org/docs/rules/no-unsafe-optional-chaining check at ci/eslint/aegir level for now? (cc @hugomrdias)
|
I don't think that rule would do it, we'd want to disallow optional chaining altogether rather than just when the thing we think the property of is optional is undefined itself. |
hugomrdias
approved these changes
May 25, 2021
achingbrain
deleted the
fix/remove-optional-chaining-from-code-that-will-be-transpiled
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional chaining is supported in node and in browsers but tools that
transpile code to run in older browsers doesn't understand the syntax.
Specifically the version of acorn that at least vue uses via a dependency
on webpack 4 does not support this.
It'll be fixed by them upgrading to webpack 5 but the timescale on that
is unclear, which is why we're using a prerelease version in our examples.
The short term fix is to just remove optional chaining from where we
are using it in code that will be transpiled for browser use.