Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix(cli): start fixing files add #483

Merged
merged 1 commit into from
Sep 13, 2016
Merged

fix(cli): start fixing files add #483

merged 1 commit into from
Sep 13, 2016
+103 −42

Conversation

dignifiedquire
Copy link
Member

Fixes #480

@dignifiedquire dignifiedquire self-assigned this Sep 12, 2016
@dignifiedquire dignifiedquire changed the title [WIP] fix(cli): start fixing files add fix(cli): start fixing files add Sep 13, 2016
daviddias
daviddias reviewed Sep 13, 2016
View reviewed changes
src/cli/commands/files/add.js

// pull-stream -> stream -> pull-stream
// is not a good idea, so if we have a pull interface
// available, use it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/comment/TODO revisit when interface-ipfs-core exposes a pull-streams API

@daviddias
Copy link
Member

daviddias commented Sep 13, 2016 •
edited
Loading

@dignifiedquire did you had the chance to try this add against a go-ipfs running daemon? (same thing for cat, and get). Also, CR'ed :)

@dignifiedquire
Copy link
Member Author

@diasdavid that's how I tested interop yesternight

@dignifiedquire
Copy link
Member Author

@diasdavid should be ready now

@daviddias daviddias merged commit c346c54 into master Sep 13, 2016
@daviddias daviddias deleted the fix-online-add branch September 13, 2016 21:33
@daviddias daviddias removed the status/in-progress In progress label Sep 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@daviddias daviddias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dignifiedquire @daviddias