Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix(cli): Fix issue with right cwd not being set #503

Merged
merged 1 commit into from
Sep 23, 2016

Conversation

victorb
Copy link
Member

@victorb victorb commented Sep 17, 2016

Be explicit about where to grab package information from, fixes #497

@victorb victorb added the status/in-progress In progress label Sep 17, 2016
@dignifiedquire
Copy link
Member

sweet thank you :)

@dignifiedquire
Copy link
Member

@victorbjelkholm do you think you could add a test for this? I would really like to get into the habbit of having tests when fixing bugs, so we don't get any regressions.

@victorb
Copy link
Member Author

victorb commented Sep 21, 2016

@dignifiedquire have any ideas on how? Was thinking I can control output of __dirname but didn't find out how...

@dignifiedquire
Copy link
Member

@victorbjelkholm you could do sth like this:

> mkdir /tmp/ipfs-test
> cd /tmp/ipfs-test
> ln -s PATH_TO_JS_IPFS .
> IPFS_PATH=/tmp/my-repo node src/cli/bin.js init 

@daviddias
Copy link
Member

💯 for fixing it
👍 for the test
💟 thank you :)

@victorb
Copy link
Member Author

victorb commented Sep 22, 2016

@dignifiedquire @diasdavid test added! nexpect provided a handy {cwd: '/tmp'} thing I could set.

@dignifiedquire
Copy link
Member

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsipfs doesn't work outside of its repo folder
3 participants