Add basic sharness tests #504

chriscool · 2016-09-22T16:56:25Z

This is to start testing js-ipfs in the same way as go-ipfs.
See issue #412 (Sharness tests).

daviddias · 2016-09-26T10:07:21Z

\o/ Thank you @chriscool :D

Do all of these run for you? Found any issues? Can I get a status of this endeavour?

I know you have been trying to reach me through IRC, unfortunately, with DEVCON2 I wasn't the most available. I'll have good wifi when the 29th of September comes.

chriscool · 2016-09-26T12:23:36Z

There are a few that don't pass. For example I think the first to fail is the 5st or the 6st because jsipfs version --all doesn't work properly.
If you want I can change the last commit to use test_expect_failure for those that don't pass.
But I think it can still be interesting to commit this as it makes it possible for other developers and CI tools to try to run the tests and see what fails.

The Makefile also implements make help that provides a bit of help to run the tests.

dignifiedquire · 2016-09-26T12:50:20Z

I think it would be good to leave the failing as failing for now so we can make a list and check things off :)

daviddias · 2016-09-28T20:17:26Z

Yeah, add all the tests @chriscool, if they fail, the better, more stuff for us to fix :D

@chriscool idealy, we want:

A PR that sets up the sharding tests (the ones that pass already) and then
PR for each of the subcommands, with all the tests, highlighting the ones that fail

chriscool · 2016-10-03T07:47:19Z

@diasdavid ok, I removed failing tests from t0010, so now everything should pass and you can merge this.
I am preparing other PRs, some that add passing tests, some that add failing tests.
I will send them when this PR will be merged, as they are based on it.

chriscool · 2016-10-03T08:03:28Z

By the way, tests should either be run using make or make deps should be used before running the tests.

This is because a symbolic link from 'js-ipfs/test/bin/ipfs' to 'js-ipfs/src/cli/bin.js' is used to make it possible for the tests to run without having to change them much.

The path to 'js-ipfs/test/bin' is added into PATH by test-lib.sh which is sourced by all the test scripts.

chriscool · 2016-10-03T08:26:47Z

This last commit adds a check and improves the error message.

daviddias · 2016-10-03T15:19:49Z

test/ipfs-test-lib.sh

@@ -0,0 +1,107 @@
+# Generic test functions for go-ipfs


I guess we can start calling it the IPFS cli :)

Year, sure I will change that.

Changed to: # Generic test functions for ipfs cli tests

daviddias · 2016-10-03T15:20:57Z

test/sharness/Makefile

+	@which curl >/dev/null || (echo "Please install curl!" && false)
+
+.PHONY: all help clean clean-test-results $(T) aggregate deps sharness
+


can we bring the Makefile to the root, so we can run it on CI by adding a line with make to:

https://github.com/ipfs/js-ipfs/blob/master/.travis.yml#L14

In go-ipfs there is also a Makefile at the root, but it is different.
You use make test at the root and make when you are in test/sharness.
I can do something like that but it could go into another PR I think as it is related to the whole project.

@chriscool what I'm looking for is to be able to add these sharness tests to CI before this merge. Can we get that added?

Yes, with the last commit I added you can just run make test at the root.
I will add that to the '.travis.yml'.

I added that and it works.

daviddias · 2016-10-03T15:21:39Z

test/sharness/lib/test-lib-hashes.sh

+HASH_WELCOME_DOCS="QmYwAPJzv5CZsnA625s3Xf2nemtYgPpHdWEz79ojWnPbdG"
+HASH_GATEWAY_ASSETS="QmXB7PLRWH6bCiwrGh2MrBBjNkLv3mY3JdYXCikYZSwLED"
+HASH_HELP_PAGE="QmY5heUM5qgRubMDD1og9fhCPA6QdkMp3QCwd4s7gJsyE7"
+HASH_EMPTY_DIR="QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn"


Apparently, these change often (//cc @lgierth) how does go-ipfs handle it? Changing it manually everytime?

It doesn't change so often, so I think manually is fine for now.
Last time they changed was in January.

We update them manually here every time we update them in go-ipfs

daviddias · 2016-10-03T15:24:02Z

\o/ woot!

There is a lot of bash magic, but they do work for me, so awesome! :D

small request https://github.com/ipfs/js-ipfs/pull/504/files#r81572723

Once we have CI running these, I'm happy to merge. Then we can see all the remaining PR's for each subcommand coming in :)

Super excited about this, getting the same level of robustness as the Go implementation 🌟

This Makefile is just to launch Sharness tests for now.

chriscool · 2016-10-03T15:48:57Z

@diasdavid just pushed with the following changes:

added a Makefile at the root as in the last commit,
changed the first line of test/ipfs-test-lib.sh

whyrusleeping · 2016-10-04T06:06:29Z

This all LGTM. Its just the base sharness setup, same as in go-ipfs

chriscool · 2016-10-16T13:06:56Z

@diasdavid could you take a look at merging this?

daviddias · 2016-10-16T13:09:08Z

@chriscool done, thank you :)

Can you start opening the PR for each of the subcommands now? If possible, listing which tests fail, so that we can fix them :)

chriscool · 2016-10-16T13:10:22Z

@diasdavid ok I will do that now.

test: add sharness support files

c8bf698

jbenet added the status/deferred Conscious decision to pause or backlog label Sep 22, 2016

daviddias added the milestone 2 label Sep 26, 2016

chriscool force-pushed the add-basic-sharness-tests branch from 5d5d360 to c264f74 Compare October 3, 2016 07:42

daviddias reviewed Oct 3, 2016

View reviewed changes

chriscool added 10 commits October 3, 2016 17:34

test: add ipfs-test-lib.sh

2c960bf

test/sharness: unignore 'lib' directory below

d88f82b

test/sharness: add lib/test-lib-hashes.sh

caf7f6f

test/sharness: add lib/iptb-lib.sh

92a5ca6

test/sharness: add lib/test-lib.sh

166465a

test: ignore bin/

cb58707

sharness: improve the Makefile

1635957

sharness: add t0010-basic-commands.sh

25f0f83

test-lib: properly check the 'ipfs' tool we use

398cd6c

Add Makefile at the root

c0f1c5d

This Makefile is just to launch Sharness tests for now.

chriscool force-pushed the add-basic-sharness-tests branch from 1a56722 to c0f1c5d Compare October 3, 2016 15:46

.travis: add 'make test' script

322d10c

daviddias merged commit 7515aec into ipfs:master Oct 16, 2016

daviddias removed the milestone 2 label Oct 16, 2016

MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020

fix: reword resolve test with async/await (ipfs#504)

3f7410a

This was referenced Apr 7, 2022

[Snyk] Fix for 1 vulnerabilities rtpro/js-ipfs#53

Open

[Snyk] Fix for 1 vulnerabilities thexdesk/js-ipfs#14

Open

[Snyk] Fix for 1 vulnerabilities thexdesk/js-ipfs#15

Open

awaisab172 mentioned this pull request Jun 21, 2023

[Snyk] Security upgrade libp2p from 0.26.2 to 0.27.0 awaisab172/js-ipfs#57

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add basic sharness tests #504

Add basic sharness tests #504

chriscool commented Sep 22, 2016

daviddias commented Sep 26, 2016

chriscool commented Sep 26, 2016

dignifiedquire commented Sep 26, 2016

daviddias commented Sep 28, 2016

chriscool commented Oct 3, 2016

chriscool commented Oct 3, 2016 •

edited

Loading

chriscool commented Oct 3, 2016

daviddias Oct 3, 2016

chriscool Oct 3, 2016

chriscool Oct 3, 2016

daviddias Oct 3, 2016

chriscool Oct 3, 2016

daviddias Oct 3, 2016 •

edited

Loading

chriscool Oct 4, 2016

chriscool Oct 4, 2016

daviddias Oct 3, 2016

chriscool Oct 3, 2016

whyrusleeping Oct 4, 2016

daviddias commented Oct 3, 2016 •

edited by chriscool

Loading

chriscool commented Oct 3, 2016

whyrusleeping commented Oct 4, 2016

chriscool commented Oct 16, 2016

daviddias commented Oct 16, 2016

chriscool commented Oct 16, 2016

		@which curl >/dev/null \|\| (echo "Please install curl!" && false)

		.PHONY: all help clean clean-test-results $(T) aggregate deps sharness

Add basic sharness tests #504

Add basic sharness tests #504

Conversation

chriscool commented Sep 22, 2016

daviddias commented Sep 26, 2016

chriscool commented Sep 26, 2016

dignifiedquire commented Sep 26, 2016

daviddias commented Sep 28, 2016

chriscool commented Oct 3, 2016

chriscool commented Oct 3, 2016 • edited Loading

chriscool commented Oct 3, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daviddias Oct 3, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daviddias commented Oct 3, 2016 • edited by chriscool Loading

chriscool commented Oct 3, 2016

whyrusleeping commented Oct 4, 2016

chriscool commented Oct 16, 2016

daviddias commented Oct 16, 2016

chriscool commented Oct 16, 2016

chriscool commented Oct 3, 2016 •

edited

Loading

daviddias Oct 3, 2016 •

edited

Loading

daviddias commented Oct 3, 2016 •

edited by chriscool

Loading