Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

sharness: t0010- jsipfs version #518

Merged
merged 2 commits into from
Feb 13, 2017
Merged

sharness: t0010- jsipfs version #518

merged 2 commits into from
Feb 13, 2017

Conversation

chriscool
Copy link
Contributor

This add some failing tests.

The first failure is:

expecting success: 
        ipfs version --all > version_all.txt &&
        grep "go-ipfs version" version_all.txt &&
        grep "Repo version" version_all.txt &&
        grep "System version" version_all.txt &&
        grep "Golang version" version_all.txt

not ok 5 - ipfs version --all has all required fields

This is because jsipfs version --all returns "js-ipfs version: 0.17.0" while:

$ ipfs version --all
go-ipfs version: 0.4.4-dev-8830aae
Repo version: 4
System version: amd64/linux
Golang version: go1.5.3

I understand that jsipfs cannot give a go-ipfs version or a golang version, but it could give equivalent information about the js-ipfs version and the js engine.

In go-ipfs reports we ask users to copy paste the output of ipfs version --all when filling an issue. If js-ipfs also implements that you could also ask users to do the same thing.

@Kubuxu Kubuxu added the status/in-progress In progress label Oct 16, 2016
@chriscool
Copy link
Contributor Author

cc @diasdavid

@daviddias daviddias mentioned this pull request Nov 12, 2016
@daviddias daviddias added js-ipfs-ready and removed status/in-progress In progress labels Nov 21, 2016
@daviddias daviddias added status/deferred Conscious decision to pause or backlog and removed js-ipfs-ready labels Dec 5, 2016
@daviddias daviddias changed the title t0010: add failing tests t0010: jsipfs version Dec 15, 2016
@daviddias daviddias added status/ready Ready to be worked help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up and removed status/deferred Conscious decision to pause or backlog labels Dec 18, 2016
@daviddias daviddias added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Jan 29, 2017
@daviddias daviddias changed the title t0010: jsipfs version sharness: t0010- jsipfs version Feb 1, 2017
@daviddias daviddias force-pushed the add-failing-t0010-tests branch from 7bf4e8e to 87782ea Compare February 13, 2017 21:26
@daviddias daviddias merged commit 7cf60bb into master Feb 13, 2017
@daviddias daviddias deleted the add-failing-t0010-tests branch February 13, 2017 21:26
@daviddias daviddias removed the status/deferred Conscious decision to pause or backlog label Feb 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants