This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Deamon init msg #631
Closed
Deamon init msg #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
suggested changes
Nov 28, 2016
There was a problem hiding this comment.
Tests fail:
1) cli --all daemon gives error if user hasn't run init before:
Error: Timeout of 1000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.
Also, please follow: https://github.com/ipfs/community/blob/master/js-commit-guidelines.md
|
@diasdavid thanks for the CR! That's weird, only fails in Travis. Passes locally for me as well. I'll look it, and I'll fix the commit messages, sorry about that... |
victorb
force-pushed
the
deamon-init-msg
branch
from
a56508d to
ed38240
Compare
victorb
force-pushed
the
deamon-init-msg
branch
from
ed38240 to
fa7e275
Compare
|
Closing this in favor of #633 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just output a similar message as go-ipfs if you run
ipfs daemonbefore having init a repo.