Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Add /api/v0/config/replace endpoint #75

Merged
merged 2 commits into from
Mar 4, 2016

Conversation

fbaiodias
Copy link
Member

Implements the /api/v0/config/replace as specified at ipfs-inactive/http-api-spec#29

Uses ipfs-multipart to process the payload that js-ipfs-api sends.

Related to #49 & similar to #72 & #74 🚀

@daviddias
Copy link
Member

woot! :) let's wait for Travis


exports.replace = {
// pre request handler that parses the args and returns `config` which is assigned to `request.pre.args`
parseArgs: (request, reply) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be better to call it parseMultipart

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was trying to keep consistency with the getOrSet endpoint, as the config file is still an argument :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@daviddias daviddias mentioned this pull request Mar 4, 2016
14 tasks
@fbaiodias fbaiodias mentioned this pull request Mar 4, 2016
daviddias added a commit that referenced this pull request Mar 4, 2016
@daviddias daviddias merged commit 015ab10 into master Mar 4, 2016
@daviddias daviddias deleted the feature/http-api-config-replace branch March 4, 2016 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants