This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Refactor HTTP API routes #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,7 +46,7 @@ exports.start = (callback) => { | |||
| server.connection({ host: gateway[2], port: gateway[4], labels: 'Gateway' }) | |||
|
|
|||
| // load routes | |||
| require('./routes') | |||
| require('./routes')(server.select('API')) | |||
There was a problem hiding this comment.
pass the server object completely and let the routes decide where to attach
fbaiodias
force-pushed
the
refactor/http-api-routes
branch
from
293765a to
8e0cb1f
Compare
|
Added the ipfs version test with the daemon running again, now fixed |
|
thank you yet again @xicombd :D :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use dependency injection on routes so that we can start and stop the http-api multiple times without issues on the tests.
UpdatedGot similar bug to #70jsipfs versionto work with the api running and added a test to make sure it works :)