This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
swarm - move isConnected filter from addrs to peers #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumavis
force-pushed
the
swarm-peers-addrs-filter-fix
branch
from
3c1dcee to
8735a08
Compare
daviddias
approved these changes
Jul 7, 2017
|
This should have included a fix to the tests as well, because this seems to not have been caught in any tests. |
dryajov
pushed a commit
that referenced
this pull request
Sep 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we sre accidentally filtering for isConnected on
swarm.addrinstead ofswarm.peersdiscussion here https://github.com/libp2p/js-libp2p-swarm/issues/221