-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
Depends on ipfs/js-ipfs-repo#30 getting merged to pass tests / work. |
opts.bits = opts.bits || 2048 | ||
|
||
// Pre-set config values. | ||
var config = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nicer if this was a separate json file, so it's easier/clearer when things change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Thank you @noffle! :D This is great. I've made some comments, seems like we need to get the files branch merged in order to unlock Note: I broke |
The latest batch of commits includes the default assets for Node-only, and tests. |
} else { | ||
return true | ||
} | ||
return !(key.endsWith('-node.js') || key.endsWith('-node')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
FYI, I still need to add the CLI and HTTP routes & tests. |
Excellent @noffle ! This is awesome. Made a request in one of the comments, let me know if you would like do it for this PR. Either way, let's squash all commits before the merge, please :) |
re: #91 (comment) Sounds good :) |
Big 'ol rebase! |
Clarification: I'm going to add HTTP/CLI in another PR; it's more work than I expected! |
LGTM, going to merge :) |
* Upgrade to GitHub-native Dependabot * chore: remove ignores Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Alex Potsides <alex@achingbrain.net>
This implements most of the IPFS initialization steps: