-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sure exec matches the passed node type #184
Conversation
Codecov Report
@@ Coverage Diff @@
## master #184 +/- ##
=========================================
Coverage ? 89.36%
=========================================
Files ? 11
Lines ? 555
Branches ? 0
=========================================
Hits ? 496
Misses ? 59
Partials ? 0
Continue to review full report at Codecov.
|
@diasdavid can we get this one merged, its needed for ipfs/interop#5 |
@@ -93,6 +92,7 @@ | |||
"dirty-chai": "^2.0.1", | |||
"go-ipfs-dep": "0.4.13", | |||
"ipfs": "^0.27.5", | |||
"ipfs-api": "^17.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dryajov only realized after that ipfs-api is now a devDep. Does this mean that folks have to pass ipfs-api everytime they want to spawn a node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It continues to be a prod dep https://github.com/ipfs/js-ipfsd-ctl/blob/master/src/daemon-node.js#L5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the rationale behind moving it?
No description provided.