feat: add js-kubo-rpc-client #764

SgtPooki · 2022-08-19T21:49:18Z

see ipfs/kubo#9125 and ipfs/js-kubo-rpc-client#3

fixes ipfs/js-kubo-rpc-client#3

see ipfs/kubo#9125

.aegir.js

SgtPooki · 2022-09-19T19:01:07Z

@lidel I removed the USE_KUBO_JS env var and just passed as overrides to ipfsd-ctl now. should be good to go on this PR

achingbrain

I think it's worth adding a test that uses the kubo rpc client

lidel

iiuc test/*.spec.js still use js-ipfs-http-client for talking to Kubo? (e.g., controller one)
I think you need to either refactor them to use js-kubo-rpc-client instead, or duplicate, so we test both.

SgtPooki · 2022-09-21T18:04:53Z

Good catch, i'm not sure how I missed that. Updated and added logging to ensure that we're using the module we think we're using.

SgtPooki · 2022-09-21T19:30:47Z

Log of running DEBUG='ipfsd-ctl:*rpcModule*' npm run test &> test.log.txt test.log.txt

SgtPooki · 2022-09-21T19:45:32Z

iiuc test/*.spec.js still use js-ipfs-http-client for talking to Kubo? (e.g., controller one) I think you need to either refactor them to use js-kubo-rpc-client instead, or duplicate, so we test both.

There are already tests using kubo via ipfsd-ctl's type: 'go' so I just updated controller.spec.js so that it's using kuboRpcModule now. That should be sufficient.. I don't think adding a new test will gain us anything right now because they're essentially the same packages.

achingbrain

LGTM, just a few small tweaks required

src/ipfsd-daemon.js

src/ipfsd-client.js

package.json

README.md

Converts this module to typescript

achingbrain · 2022-09-30T13:09:01Z

I've done the typescript conversion work in #777 (like #776 but without the changes from this PR).

I don't want to merge it off the bat as it'll stomp all over these changes - if it's not a totally outrageous request, could you try integrating kubo-rpc-client in a PR targeting the branch from #777 - it'll likely give us a bit more confidence over the types as the jsdoc stuff is pretty limited.

…pescript

SgtPooki · 2022-10-03T22:28:12Z

package.json

@@ -152,13 +152,15 @@
    "wherearewe": "^2.0.1"
  },
  "devDependencies": {
+    "@libp2p/interfaces": "^3.0.3",


without this, ipfs-core-types was failing on a lack of types from @libp2p/interfaces/events from the line import type { EventHandler } from '@libp2p/interfaces/events'

…c-client

SgtPooki · 2022-10-03T23:13:54Z

tests seem to be stuck on this PR for some reason.. running them at https://github.com/SgtPooki/js-ipfsd-ctl/actions/runs/3178121664

changes made

SgtPooki · 2022-10-04T18:10:08Z

@achingbrain CI is passing

BigLep · 2022-10-04T19:59:56Z

@SgtPooki : that's great.

@achingbrain : any concerns with merging? I want get @SgtPooki unblocked. If it's not ok to merge, can you lay out what the conditions for merging will be?

achingbrain

LGTM, just a couple of small nits and it's good to go.

src/index.ts

achingbrain · 2022-10-05T08:56:18Z

package.json

@@ -152,13 +152,15 @@
    "wherearewe": "^2.0.1"
  },
  "devDependencies": {
+    "@libp2p/interfaces": "^3.0.3",


This dep is added but doesn't appear to be used anywhere?

Suggested change

"@libp2p/interfaces": "^3.0.3",

When removing this, ipfs-core-types throws an error

@SgtPooki : a couple of thoughts:

Do you want to paste in the error observed to aid in understanding or debugging?

assuming getting this merged is blocking other work you're trying to do for the js-kubo-rpc-client, I think it's safe to merge and then we fast-followup if there's something deeper to address that @achingbrain calls out.

pushing up a change removing this to see if CI still passes.

@BigLep thanks for chiming in. I was keeping an eye out for the error. I did already comment on the file changes with the error. I was going to share it in the CI if seen there, but it looks like it's going to pass

## [12.2.0](v12.1.1...v12.2.0) (2022-10-05) ### Features * add js-kubo-rpc-client ([#764](#764)) ([9538c1d](9538c1d))

github-actions · 2022-10-05T19:46:18Z

🎉 This PR is included in version 12.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat: add js-kubo-rpc-client

20ea2f9

see ipfs/kubo#9125

SgtPooki mentioned this pull request Aug 23, 2022

Add kuboRpcModule support to ipfs/js-ipfsd-ctl ipfs/js-kubo-rpc-client#3

Closed

chore: update kubo-rpc-client package name

cb0e10b

SgtPooki requested review from achingbrain, guseggert and lidel September 6, 2022 20:24

fix: use cross-env to set USE_KUBO_JS

7fa9e7e

lidel reviewed Sep 7, 2022

View reviewed changes

.aegir.js Outdated Show resolved Hide resolved

SgtPooki mentioned this pull request Sep 19, 2022

feat: add kubo-rpc-client ipfs/interop#499

Merged

SgtPooki added 2 commits September 19, 2022 11:42

Merge branch 'ipfs:master' into feature/add-js-kubo-rpc-client

3b775f0

fix: Remove USE_KUBO_JS env var

ee3b36a

SgtPooki requested a review from lidel September 20, 2022 03:56

chore(deps): remove cross-env

60c2c84

achingbrain approved these changes Sep 20, 2022

View reviewed changes

achingbrain self-requested a review September 20, 2022 17:11

achingbrain requested changes Sep 20, 2022

View reviewed changes

lidel previously requested changes Sep 20, 2022

View reviewed changes

SgtPooki added 3 commits September 21, 2022 10:46

docs(readme): update npm install cmds for using kubo-rpc-client

004ebc6

chore: log whether kubo-rpc-client or ipfs-http-client is in use

b828341

chore(tests): use kubo-rpc-client for commmunication with go controllers

e4e8bb5

SgtPooki added 3 commits September 21, 2022 11:06

Merge branch 'master' into feature/add-js-kubo-rpc-client

3db2fb5

chore(lint): fix lint failure

ab88fed

fix: addCorrectRpcModule returns the additionalOpts object

0ed3917

SgtPooki requested review from lidel and achingbrain September 21, 2022 19:43

achingbrain previously requested changes Sep 22, 2022

View reviewed changes

src/ipfsd-daemon.js Outdated Show resolved Hide resolved

src/ipfsd-client.js Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

SgtPooki and others added 4 commits September 23, 2022 11:59

chore(deps): use kubo-rpc-client@1.0.1

cb4c373

feat!: convert to typescript

5783286

Converts this module to typescript

chore: fix linting

2f98a0b

chore: fix tests

3a78c13

SgtPooki and others added 3 commits September 30, 2022 13:54

Merge branch 'feature/add-js-kubo-rpc-client' into feat/convert-to-ty…

feadf53

…pescript

chore: apply suggestions from code review

86aec67

fix: resolve issues with js-kubo-rpc-client in typescript

919e03f

SgtPooki changed the base branch from master to feat/convert-to-typescript October 3, 2022 22:26

SgtPooki commented Oct 3, 2022

View reviewed changes

SgtPooki added 2 commits October 3, 2022 15:29

fix: use kuboRpcModule for go in factory.spec.ts

0635198

Merge branch 'feat/convert-to-typescript' into feature/add-js-kubo-rp…

d1fa4c0

…c-client

SgtPooki changed the base branch from feat/convert-to-typescript to master October 3, 2022 23:01

SgtPooki marked this pull request as draft October 3, 2022 23:06

SgtPooki marked this pull request as ready for review October 3, 2022 23:06

SgtPooki mentioned this pull request Oct 3, 2022

Feature/add js kubo rpc client SgtPooki/js-ipfsd-ctl#1

Merged

SgtPooki added 2 commits October 4, 2022 09:20

chore: merge master

baa5ffb

fix: broken build from bad merge

d3afe62

achingbrain approved these changes Oct 5, 2022

View reviewed changes

chore: address PR comments

30db4db

SgtPooki merged commit 9538c1d into ipfs:master Oct 5, 2022

SgtPooki deleted the feature/add-js-kubo-rpc-client branch October 5, 2022 19:23

github-actions bot pushed a commit that referenced this pull request Oct 5, 2022

chore(release): 12.2.0 [skip ci]

10fcf18

## [12.2.0](v12.1.1...v12.2.0) (2022-10-05) ### Features * add js-kubo-rpc-client ([#764](#764)) ([9538c1d](9538c1d))

github-actions bot added the released label Oct 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add js-kubo-rpc-client #764

feat: add js-kubo-rpc-client #764

SgtPooki commented Aug 19, 2022 •

edited

Loading

SgtPooki commented Sep 19, 2022

achingbrain left a comment

lidel left a comment

SgtPooki commented Sep 21, 2022

SgtPooki commented Sep 21, 2022

SgtPooki commented Sep 21, 2022

achingbrain left a comment

achingbrain commented Sep 30, 2022 •

edited

Loading

SgtPooki Oct 3, 2022

SgtPooki commented Oct 3, 2022

SgtPooki commented Oct 4, 2022

BigLep commented Oct 4, 2022

achingbrain left a comment

achingbrain Oct 5, 2022

SgtPooki Oct 5, 2022

BigLep Oct 5, 2022

SgtPooki Oct 5, 2022

SgtPooki Oct 5, 2022

github-actions bot commented Oct 5, 2022

feat: add js-kubo-rpc-client #764

feat: add js-kubo-rpc-client #764

Conversation

SgtPooki commented Aug 19, 2022 • edited Loading

SgtPooki commented Sep 19, 2022

achingbrain left a comment

Choose a reason for hiding this comment

lidel left a comment

Choose a reason for hiding this comment

SgtPooki commented Sep 21, 2022

SgtPooki commented Sep 21, 2022

SgtPooki commented Sep 21, 2022

achingbrain left a comment

Choose a reason for hiding this comment

achingbrain commented Sep 30, 2022 • edited Loading

SgtPooki Oct 3, 2022

Choose a reason for hiding this comment

SgtPooki commented Oct 3, 2022

SgtPooki commented Oct 4, 2022

BigLep commented Oct 4, 2022

achingbrain left a comment

Choose a reason for hiding this comment

achingbrain Oct 5, 2022

Choose a reason for hiding this comment

SgtPooki Oct 5, 2022

Choose a reason for hiding this comment

BigLep Oct 5, 2022

Choose a reason for hiding this comment

SgtPooki Oct 5, 2022

Choose a reason for hiding this comment

SgtPooki Oct 5, 2022

Choose a reason for hiding this comment

github-actions bot commented Oct 5, 2022

SgtPooki commented Aug 19, 2022 •

edited

Loading

achingbrain commented Sep 30, 2022 •

edited

Loading