Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: re-enable tests that use isOnline #825

Merged
merged 2 commits into from
Apr 19, 2024
Merged

chore: re-enable tests that use isOnline #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01708c7
chore: re-enable tests that use isOnline
achingbrain Apr 19, 2024
c6df9b2
Merge branch 'master' into chore/enable-offline-tests
achingbrain Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
"@libp2p/logger": "^4.0.10",
"execa": "^8.0.1",
"joi": "^17.2.1",
"kubo-rpc-client": "^4.0.0",
"kubo-rpc-client": "^4.0.1",
"merge-options": "^3.0.1",
"nanoid": "^5.0.7",
"p-defer": "^4.0.1",
Expand Down
3 changes: 1 addition & 2 deletions test/controller.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,7 @@ describe('Node API', function () {
})

describe('stop', () => {
// https://github.com/ipfs/js-kubo-rpc-client/pull/222
describe.skip('should stop the node', () => {
describe('should stop the node', () => {
for (const opts of types) {
it(`type: ${opts.type} remote: ${Boolean(opts.remote)}`, async () => {
const node = await factory.spawn(opts)
Expand Down
6 changes: 2 additions & 4 deletions test/factory.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,7 @@ describe('`Factory spawn()` ', function () {
}
})

// https://github.com/ipfs/js-kubo-rpc-client/pull/222
describe.skip('`Factory.clean()` should stop all nodes', () => {
describe('`Factory.clean()` should stop all nodes', () => {
let factory: Factory

afterEach(async () => {
Expand All @@ -127,8 +126,7 @@ describe('`Factory spawn()` ', function () {
}
})

// https://github.com/ipfs/js-kubo-rpc-client/pull/222
describe.skip('`Factory.clean()` should not error when controller already stopped', () => {
describe('`Factory.clean()` should not error when controller already stopped', () => {
let factory: Factory

afterEach(async () => {
Expand Down
Loading