Merge pull request #6399 from Wondertan/fix/lifecycle-helper

Usage of context helper in Blockstore provider
ipfs · Jun 4, 2019 · 5311ac0 · 5311ac0
2 parents 03e2eee + 1f1c68f
commit 5311ac0
Showing 1 changed file with 1 addition and 10 deletions.
diff --git a/core/node/storage.go b/core/node/storage.go
@@ -1,7 +1,6 @@
 package node
 
 import (
-	"context"
 	"os"
 	"syscall"
 	"time"
@@ -55,15 +54,7 @@ func BaseBlockstoreCtor(cacheOpts blockstore.CacheOpts, nilRepo bool, hashOnRead
 		bs = &verifbs.VerifBS{Blockstore: bs}
 
 		if !nilRepo {
-			ctx, cancel := context.WithCancel(mctx)
-
-			lc.Append(fx.Hook{
-				OnStop: func(context context.Context) error {
-					cancel()
-					return nil
-				},
-			})
-			bs, err = blockstore.CachedBlockstore(ctx, bs, cacheOpts)
+			bs, err = blockstore.CachedBlockstore(helpers.LifecycleCtx(mctx, lc), bs, cacheOpts)
 			if err != nil {
 				return nil, err
 			}