move fs-specific objects into own pkg #146
Comments
|
I like that idea, ill code that up. |
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this issue
Feb 25, 2022
* remove the EnableRelayHop option in the SwarmConfig * add an option to disable the limited relay * make the relay service resources configurable * refactor: use custom types This enables us to swap defaults in go-ipfs without touching the config file generated during `ipfs init` ipfs/go-ipfs-config#146 (comment) ipfs/go-ipfs-config#146 (comment) * use OptionalDuration in RelayService configuration * fix: *OptionalInteger with omitempty This removes null values from the config * fix: Flag does not need to be a pointer * refactor: flatten RelayService limits this simplifies consumer code and removes nil footgun * docs: clarify different relay types * feat: flag for ForceReachability mode in libp2p (ipfs#150) adds Internal.Libp2pForceReachability needed for sharness tests in ipfs#8522 Co-authored-by: Marcin Rataj <lidel@lidel.org> Co-authored-by: Marcin Rataj <lidel@lidel.org>
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this issue
Feb 25, 2022
* remove the EnableRelayHop option in the SwarmConfig * add an option to disable the limited relay * make the relay service resources configurable * refactor: use custom types This enables us to swap defaults in go-ipfs without touching the config file generated during `ipfs init` ipfs/go-ipfs-config#146 (comment) ipfs/go-ipfs-config#146 (comment) * use OptionalDuration in RelayService configuration * fix: *OptionalInteger with omitempty This removes null values from the config * fix: Flag does not need to be a pointer * refactor: flatten RelayService limits this simplifies consumer code and removes nil footgun * docs: clarify different relay types * feat: flag for ForceReachability mode in libp2p (ipfs#150) adds Internal.Libp2pForceReachability needed for sharness tests in ipfs#8522 Co-authored-by: Marcin Rataj <lidel@lidel.org> Co-authored-by: Marcin Rataj <lidel@lidel.org>
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this issue
Mar 4, 2022
* remove the EnableRelayHop option in the SwarmConfig * add an option to disable the limited relay * make the relay service resources configurable * refactor: use custom types This enables us to swap defaults in go-ipfs without touching the config file generated during `ipfs init` ipfs/go-ipfs-config#146 (comment) ipfs/go-ipfs-config#146 (comment) * use OptionalDuration in RelayService configuration * fix: *OptionalInteger with omitempty This removes null values from the config * fix: Flag does not need to be a pointer * refactor: flatten RelayService limits this simplifies consumer code and removes nil footgun * docs: clarify different relay types * feat: flag for ForceReachability mode in libp2p (ipfs#150) adds Internal.Libp2pForceReachability needed for sharness tests in ipfs#8522 Co-authored-by: Marcin Rataj <lidel@lidel.org> Co-authored-by: Marcin Rataj <lidel@lidel.org>
laurentsenta
pushed a commit
to laurentsenta/kubo
that referenced
this issue
Mar 4, 2022
* remove the EnableRelayHop option in the SwarmConfig * add an option to disable the limited relay * make the relay service resources configurable * refactor: use custom types This enables us to swap defaults in go-ipfs without touching the config file generated during `ipfs init` ipfs/go-ipfs-config#146 (comment) ipfs/go-ipfs-config#146 (comment) * use OptionalDuration in RelayService configuration * fix: *OptionalInteger with omitempty This removes null values from the config * fix: Flag does not need to be a pointer * refactor: flatten RelayService limits this simplifies consumer code and removes nil footgun * docs: clarify different relay types * feat: flag for ForceReachability mode in libp2p (ipfs#150) adds Internal.Libp2pForceReachability needed for sharness tests in ipfs#8522 Co-authored-by: Marcin Rataj <lidel@lidel.org> Co-authored-by: Marcin Rataj <lidel@lidel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
currently the fs-specific objects (file format, dagreader, etc.) are spread out across the
importerand themerkledagpackages.But the filesystem-specific stuff does not belong in regular merkledag. merkledag is lower level, it only provides the dag link structure. the fs is one of many possible datastructures on top.
We should probably have a
unixfspackage that implements the dir/file abstractions, with indirect blocks, and with its reader/writers within anunixfs.iosubpackage.The text was updated successfully, but these errors were encountered: