Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sharness t0020-init.sh fails to cleanup on OSX #2026

Closed
whyrusleeping opened this issue Dec 2, 2015 · 1 comment
Closed

sharness t0020-init.sh fails to cleanup on OSX #2026

whyrusleeping opened this issue Dec 2, 2015 · 1 comment
Assignees
@chriscool
Labels
topic/test failure Topic test failure

Comments

@whyrusleeping
Copy link
Member

on osx, the trash directory for the t0020-init.sh test fails to be removed due to a permissions error. This is likely because we're changing permissions in the test itself. Perhaps we should manually 'clean up' the changed perms in the test to make this go smoother?
@whyrusleeping whyrusleeping added the topic/test failure Topic test failure label Dec 2, 2015
@jbenet
Copy link
Member

jbenet commented Dec 2, 2015

agreed-- i've been annoyed by this in the past

@ghost ghost mentioned this issue Dec 2, 2015
Closed
3 tasks
@chriscool chriscool mentioned this issue Dec 5, 2015
Merged
@jbenet jbenet added the status/in-progress In progress label Dec 5, 2015
@jbenet jbenet removed the status/in-progress In progress label Dec 6, 2015
dignifiedquire pushed a commit to dignifiedquire/go-ipfs that referenced this issue Dec 6, 2015
@chriscool @dignifiedquire
t0020: cleanup dir with bad perms
823c664 
This is needed on OSX otherwise the trash directory for the
t0020-init.sh test fails to be removed due to a permissions
error.

This fixes ipfs#2026

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
rht pushed a commit to rht/go-ipfs that referenced this issue Dec 16, 2015
@chriscool @rht
t0020: cleanup dir with bad perms
1fae004 
This is needed on OSX otherwise the trash directory for the
t0020-init.sh test fails to be removed due to a permissions
error.

This fixes ipfs#2026

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
chriscool added a commit that referenced this issue Dec 16, 2015
@chriscool @rht
t0020: cleanup dir with bad perms
5f07a85 
This is needed on OSX otherwise the trash directory for the
t0020-init.sh test fails to be removed due to a permissions
error.

This fixes #2026

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chriscool chriscool

Labels
topic/test failure Topic test failure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbenet @chriscool @whyrusleeping