-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPFS_BOOTSTRAP / env-override of config? #251
Comments
Thats tricky to work out in a way that makes sense.... |
@whyrusleeping What challenges do you see? I don't know of any concrete use cases for other config values. I just know that env bootstrapping is important for Docker.
|
i think he means my general suggestion |
Not sure we need to worry about the general case just yet. At least not until a) the pipeline clears up a bit or b) a use case arises that shows importance of a general solution. |
fair enough |
We can keep it simple by using env vars and giving the option to extend the default config with |
@gmasgras can you comment on whether this is still relevant based on the Docker-izing work you are doing? Should it remain open? |
Here is a PR that addresses this issue: #6325 |
Continued in #387 |
As noted in #250, it would be nice to be able to pass in bootstrap addresses as part of an envvar or a cli param. This would make it easier to programmatically create nodes.
What might make sense is to design a seamless way for env vars to override configuration variables, that way we dont have to create multiple ways of changing them.
Maybe a
IPFS_CONFIG(_Key)+
->config(.Key)+
approach. (e.g.IPFS_Config_Bootstrap
)... hmm i dont like this.The text was updated successfully, but these errors were encountered: