Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfs add ignore, .ipfsignore #3643

Closed
crackcomm opened this issue Jan 29, 2017 · 10 comments
Closed

ipfs add ignore, .ipfsignore #3643

crackcomm opened this issue Jan 29, 2017 · 10 comments
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@crackcomm
Copy link

crackcomm commented Jan 29, 2017

I would love to be able to run ipfs add -w -r . but ignoring node_modules or target directory, or any other directory.
Something like .ipfsignore may be an overkill but something like this is what I am looking for.

@whyrusleeping
Copy link
Member

Yeah, i'd like to have this too. I implemented it semi-manually for gx https://github.com/whyrusleeping/gx/blob/master/gxutil/publish.go

@Kubuxu Kubuxu added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue labels Mar 15, 2017
@AlbertoElias
Copy link

Is there a way to ignore files yet?

@Stebalien
Copy link
Member

This feature was, unfortunately, blocked on one PR that was blocked on another (large) PR. Path forward:

Unfortunately, I'm not sure anyone will have time to work on this at the moment unless @crackcomm has some free time and feels like reviving their PRs.

@kjzz
Copy link
Contributor

kjzz commented Sep 21, 2018

Hey @whyrusleeping @Stebalien , Has this issue been finished?And it has aleady been blocked for one year.
If not,i am willing to do this.

@marcusnewton
Copy link

+1 good idea

@dholms
Copy link

dholms commented Nov 11, 2019

Any movement on this? It'd be very useful for us (specifically an --ignore or --exclude flag).
Happy to contribute as well, but want to check the status first since it seems like PRs addressing this (#4013) never got unblocked

@Stebalien
Copy link
Member

@dholms no progress but not blocked, as far as I know. The next step is ipfs/go-ipfs-cmdkit#5. There are two PRs (see the bottom of that issue) trying to fix that but they're kind of hacky. If you'd like to rebase/clean them up, I can take a look at them.

Note: we have quite a few high-priority issues in flight at the moment so reviews may take a while.

@bmann
Copy link
Contributor

bmann commented Nov 12, 2019

@Stebalien we're not using golang in-house at the moment, we can see if we can bounty it.

@hsanjuan
Copy link
Contributor

Heads up this issue has been picked up by @corntoole. Any feedback and review help on issues linked above from interested parties is more than welcome!

@Stebalien
Copy link
Member

Ignore file support has now been merged. You can pass:

  • --ignore=file to skip a file/directory.
  • --ignore-rules-path=.someignorefile to apply all ignore rules specified by the file.

In the future, we should consider shorter flags (maybe a -g flag to ignore files specified by .gitignore, etc.) but this is a good, mvp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants