-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strings option #4012
Add strings option #4012
Conversation
License: MIT Signed-off-by: Łukasz Kurowski <crackcomm@gmail.com>
This feature sounds good to me, makes sense to have and i can definitely see it being useful. I'd like to see some tests around this. Also, we will have to coordinate adding this feature with @keks refactor work. Shouldnt be a big deal, but definitely need to account for it. |
@crackcomm the tests failure in ci/circleci look related to your changes |
License: MIT Signed-off-by: Łukasz Kurowski <crackcomm@gmail.com>
@kevina passed now |
@crackcomm could you add a test or two to commands/cli/parse_test.go for this new flag type? |
The feature and the code LGTM. Since at this point there are zero tests, wouldn't it be better to make this change on top of #3856? If we keep changing commands that one will never get merged. |
@keks feel free to do so. |
btw. there are some tests in #4013 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@keks do you think you could introduce something like this after the commands lib rework is merged?
(cleaning out my Review queue).
Sure, I'll do that |
This should be resolved in go-ipfs-cmds if anywhere. So closing this one. |
Fixed a few days ago, actually... |
Command strings array option.
It works like that:
$ ipfs -i node_modules -i .git -i yarn.lock -r .
It's required to get #3643 done for above to work – ignoring paths.