Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api call to lookup dnslink name doesn't work #4293

Closed
bonds opened this issue Oct 9, 2017 · 3 comments · Fixed by #6087
Closed

api call to lookup dnslink name doesn't work #4293

bonds opened this issue Oct 9, 2017 · 3 comments · Fixed by #6087
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@bonds
Copy link

bonds commented Oct 9, 2017

Version information:

~ ❯❯❯ ipfs version --all                                                    Mon 2017-10-09 14:27:51 -0700
go-ipfs version: 0.4.11-dev-
Repo version: 5
System version: amd64/openbsd
Golang version: go1.8

Type: Bug

Severity: High

Description:

Using the API to resolve ggr.com doesn't work, i.e.:

https://ipfs.io/api/v0/dns/ggr.com

returns

{"Message":"Could not resolve name (recursion limit exceeded).","Code":0}

Yet, the name resolves at the CLI fine:

~/Downloads ❯❯❯ ipfs --debug name resolve -r ggr.com                        Mon 2017-10-09 12:09:19 -0700
14:09:29.683  INFO   cmd/ipfs: IPFS_PATH /home/scott/.ipfs main.go:301
14:09:29.687 DEBUG   cmd/ipfs: calling pre-command hooks... main.go:295
14:09:29.687 DEBUG   cmd/ipfs: executing command via API main.go:332
/ipfs/QmWqNxbUnGZzmLeyA8jMi1VeyuHpBcYDYH9WcYZY31zijk

See ipfs/ipfs-companion#288 for a previous discussion and more detail on this issue.

@lidel
Copy link
Member

lidel commented Aug 27, 2018

This just got a lot more awkward, lookup for ipfs.io fails with the same error 🙃

could not resolve name (recursion limit exceeded)
$ curl -s https://ipfs.io/api/v0/dns/ipfs.io
{"Message":"could not resolve name (recursion limit exceeded)","Code":0,"Type":"error"}

@Stebalien
Copy link
Member

The issue here is that the dns command isn't recursive by default. You can add ?r=true to the end to fix this.

Honestly, we should probably make these recursive by default, if possible.

@Stebalien Stebalien added kind/enhancement A net-new feature or improvement to an existing feature status/deferred Conscious decision to pause or backlog and removed kind/bug A bug in existing code (including security flaws) labels Aug 27, 2018
lidel added a commit to ipfs/ipfs-companion that referenced this issue Aug 27, 2018
@ghost
Copy link

ghost commented Aug 27, 2018

Honestly, we should probably make these recursive by default, if possible.
Yes, with a limit of 10 or so

Stebalien added a commit that referenced this issue Mar 16, 2019
This is what users expect.

fixes #5635
fixes #5585
fixes #4181
fixes #4293
fixes #6086

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@ghost ghost assigned Stebalien Mar 16, 2019
@ghost ghost added status/in-progress In progress and removed status/deferred Conscious decision to pause or backlog labels Mar 16, 2019
@ghost ghost removed the status/in-progress In progress label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants