Filestore possiblly not hooked up right

[kevina]

When the filestore is used the CachedBlockstore is not according to this code (in builder.go):

	bs := bstore.NewBlockstore(rds)
	...

	cbs, err := bstore.CachedBlockstore(ctx, bs, opts)
	...

	n.BaseBlocks = cbs
	n.GCLocker = bstore.NewGCLocker()
	n.Blockstore = bstore.NewGCBlockstore(cbs, n.GCLocker)

	if conf.Experimental.FilestoreEnabled {
		...
		n.Filestore = filestore.NewFilestore(bs, n.Repo.FileManager())
		n.Blockstore = bstore.NewGCBlockstore(n.Filestore, n.GCLocker)
		...
	}

It looks like it was always this way based on 2884c84

@whyrusleeping Was this intentional or an oversight.

[whyrusleeping]

Oh, that looks like an oversight on my part.

[kevina]

@whyrusleeping So is the fix to change

n.Filestore = filestore.NewFilestore(bs, n.Repo.FileManager())

to

n.Filestore = filestore.NewFilestore(cbs, n.Repo.FileManager())

that is s/bs/cbs/?

If so I think I will just fix it in #5117. I actually noticed this bug as enabling the filestore broke id-hashes.

[whyrusleeping]

@kevina that seems right. Please do the fix in a separate PR.

[kevina]

@whyrusleeping see #5122.