Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Explosion #573

Closed
jbenet opened this issue Jan 15, 2015 · 1 comment
Closed

Address Explosion #573

jbenet opened this issue Jan 15, 2015 · 1 comment
Assignees
@jbenet
Milestone
α

Comments

@jbenet
Copy link
Member

jbenet commented Jan 15, 2015

Currently, we absorb (add to our peerstore) addresses other peers report to see us dialing from. For UDP based transports, this may be fine, as it may help with NAT traversal. However, with TCP, this is currently[1] strictly an error. There must be calls to peerstore.AddAddresses(self, <observed addr>). We should find them and destroy them. Likely places: Identify service, Swarm, Host.

[1] vanilla net.TCP* does not allow you to listen AND dial out from the same TCP port. It is on my long TODO PQ to make this possible, which would put our TCP addresses in the same camp as UDP addresses: others' reports may actually be useful. But probably should still not be added to the peerstore.
@jbenet jbenet mentioned this issue Jan 15, 2015
Closed
@jbenet jbenet modified the milestone: α Jan 15, 2015
@jbenet jbenet self-assigned this Jan 15, 2015
jbenet added a commit that referenced this issue Jan 16, 2015
@jbenet
addr-explosion mitigated adding
c057cea 
mitigated adding our own addresses where received
from peers

see #573
@jbenet jbenet mentioned this issue Jan 16, 2015
Merged
@jbenet jbenet added the status/in-progress In progress label Jan 16, 2015
@jbenet
Copy link
Member Author

jbenet commented Jan 20, 2015

This has been addressed by both #582 and #602 -- #603 is a separate issue.

@jbenet jbenet closed this as completed Jan 20, 2015
@jbenet jbenet removed the status/in-progress In progress label Jan 20, 2015
@jbenet jbenet mentioned this issue Jan 27, 2015
Merged
2 tasks
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
@jbenet
addr-explosion mitigated adding
38c3e88 
mitigated adding our own addresses where received
from peers

see ipfs#573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbenet jbenet

Labels
None yet
Projects
None yet
Milestone
α
Development

No branches or pull requests
1 participant
@jbenet