-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append Announces #7791
Comments
@Jorropo implementing one of these proposals seems reasonable. It would be helpful to know a little more context around the use case you're working on. |
Really there is none in this case, could be someone running behind a nat without nat traversal and wanting to announce his port forward while still announcing his local addrs. |
I've run into a need for this when enabling WSS. My current solution is to grab everywhere I'm announcing to, make a big list, then append my 2 new announcements to that list. It'd be a lot more intuitive to be able to just append to the usual generated list (especially with dynamic IPs...). Explicitly, currently I'm doing this:
When I think this would make more sense:
|
@TheDiscordian see proposed config in #8177 – would appreciate feedback if it is intuitive enough. |
2021-11-12 discussion: we believe this is just waiting until @lidel frees up to get this reviewed/merged. |
* feat: Addresses.AppendAnnounce Closes #7791 * fix: deduplicate Swarm.Announce and AppendAnnounce #8177 (comment) #8177 (comment) Co-authored-by: Marcin Rataj <lidel@lidel.org>
Hi, I would like to add announces on top of the listen addrs but,
currently if
len(announces) > 0
the regular addrs are replaced by the announces :https://github.com/ipfs/go-ipfs/blob/1bf8a723f95f8ca9bd5f520b0896b7afc9658a53/core/node/libp2p/addrs.go#L55-L59
I would like to create a way for announces to be added to listen addresses, not replace them.
Wich option would be fine to add ?
.Addresses.AppendAnnounce bool
key, if trueaddrs = append(allAddrs,annAddrs...)
else the current logic..Addresses.ExtraAnnounce []ma.Multiaddr
wich is always appended after the current logic.addrs = append(allAddrs,annAddrs...)
(breaking change ?).The text was updated successfully, but these errors were encountered: