Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFS remote pinning policy: log ERROR if pin failed #7917

Open
lidel opened this issue Feb 16, 2021 · 3 comments · May be fixed by #8525
Open

MFS remote pinning policy: log ERROR if pin failed #7917

lidel opened this issue Feb 16, 2021 · 3 comments · May be fixed by #8525
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/pinning Topic Pinning (local and remote)

Comments

@lidel
Copy link
Member

lidel commented Feb 16, 2021

go-ipfs 0.8.0-rc2 dispatches remote pin request but does not act on its status, so without manual inspection it is possible to miss the fact that MFS pinning (Pinning.RemoteServices.*.Policies.MFS, #7913) stopped working.

I believe we should keep checking pin status every RepinInterval until its pinned or failed, and if it's the latter, print ERROR into remotepinning/mfs logger. Pinning may fail for multiple reasons, main ones is some arbitrary timeout to find a provider for the data, another one is when you try to pin DAG bigger than allowed quota.

By printing error on MFS pin failure, node operator will be able to notice that remote pinning stopped working due to one of mentioned reasons.

cc #7559 @aschmahmann does this sound sensible?
@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up good first issue Good issue for new contributors exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours topic/pinning Topic Pinning (local and remote) labels Feb 16, 2021
@aschmahmann
Copy link
Contributor

@lidel 👍 this seems like a reasonable plan of action to me.

@aschmahmann aschmahmann added the status/ready Ready to be worked label Mar 15, 2021
@BogdanStirbat BogdanStirbat mentioned this issue Apr 6, 2021
Merged
@lidel
Copy link
Member Author

lidel commented May 17, 2021 •
edited
Loading

#8056 improved logs a bit and prints ERROR when daemon starts and checks for pre-existing pin, but we still pin asynchronously and don't track status change of ongoing pin.

Remaining work here is to continue status check until queued MFS pin got turned into pinned or failure.

@gautammenghani
Copy link

Hi I would like to give this issue a try

@gautammenghani gautammenghani linked a pull request Oct 22, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/pinning Topic Pinning (local and remote)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 7917: Fix/mfs/error pin fail gautammenghani/go-ipfs
3 participants
@lidel @aschmahmann @gautammenghani