-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Pinning.RemoteServices.Policies.MFS #7913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
reviewed
Feb 15, 2021
Co-authored-by: Adin Schmahmann <adin.schmahmann@gmail.com>
jessicaschilling
suggested changes
Feb 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few text nits and one question.
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
lidel
force-pushed
the
docs/mfs-pinning
branch
from
February 15, 2021 20:32
544574a
to
72e3e5c
Compare
lidel
commented
Feb 15, 2021
@aschmahmann I believe this is ready for your final 👀 |
jessicaschilling
approved these changes
Feb 15, 2021
petar
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
aschmahmann
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
need/review
Needs a review
topic/docs-ipfs
Topic docs-ipfs
topic/pinning
Topic Pinning (local and remote)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds docs for
Pinning.RemoteServices.Policies
cc #7559 ipfs/ipfs-docs#369 ipfs/ipfs-gui#91