Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kubo to new HTTP Delegated Routing #9422

Closed
Tracked by #9417
BigLep opened this issue Nov 18, 2022 · 6 comments · Fixed by #9475
Closed
Tracked by #9417

Update Kubo to new HTTP Delegated Routing #9422

BigLep opened this issue Nov 18, 2022 · 6 comments · Fixed by #9475
Assignees

Comments

@BigLep
Copy link
Contributor

BigLep commented Nov 18, 2022

Done Criteria

Kubo is implementing ipfs/specs#337 using the HTTP Delegated Routing version from ipfs/go-delegated-routing#63

Specifically:

  1. Add a new router type to the config, something like http or http-content-routing
  2. Remove reframe router type until its issues are resolved

Why Important

See motivation in ipfs/specs#337

Notes

@BigLep BigLep moved this to 🥞 Todo in IPFS Shipyard Team Nov 18, 2022
@BigLep BigLep changed the title Update to new HTTP Delegated Routing Update Kubo to new HTTP Delegated Routing Nov 18, 2022
@ajnavarro ajnavarro moved this from 🥞 Todo to 🏃‍♀️ In Progress in IPFS Shipyard Team Nov 24, 2022
@BigLep BigLep mentioned this issue Dec 3, 2022
@lidel
Copy link
Member

lidel commented Dec 5, 2022

Quick notes about default, implicit configuration (:point_right: based on feedback from Juan today):

  • Change routing defaults in Kubo to "DHT + implicit list of HTTP routers" (IPIP-337: Delegated Content Routing HTTP API specs#337)
    • Follow UX established for DNS
      • user's JSON config remains empty, which allows us to update/expand implicit defaults in future releases
      • user is in control and can remove/update implicit routers if they wish
        • this can be done by setting Routing.Type to custom and defining own Routing.Routers
    • only cid.contact for now, we can add Cloudflare (already used for DoH) when they run their own indexer
  • Probably a good time to switch Routing.Type to OptionalString
    • write config migration that removes Routing.Type (switching to implicit default) when value is dht
      • without this all existing nodes will be stuck with DHT-only
    • change implicit default from dht to auto and document it means DHT + specific implicit routers

@BigLep
Copy link
Contributor Author

BigLep commented Dec 6, 2022

I didn't see this earlier but I created #9454 for tracking the work of adding cid.contact as an implicit default content router.

I was imaging one PR to update the HTTP delegated routing client used by Kubo (for this issue) and then another PR for the cid.contact integration (including changelog/docs - which would be against #9454). If it makes sense to do one large PR, please go ahead.

@ajnavarro
Copy link
Member

Main integration here: #9453

lidel added a commit that referenced this issue Dec 7, 2022
This changes the default routing to to be implicit DHT+IPNI

Full context:
#9422 (comment)
lidel added a commit that referenced this issue Dec 7, 2022
This changes the default routing to to be implicit DHT+IPNI

Full context:
#9422 (comment)
lidel added a commit that referenced this issue Dec 7, 2022
This changes the default routing to to be implicit DHT+IPNI

Full context:
#9422 (comment)
lidel added a commit that referenced this issue Dec 7, 2022
This changes the default routing to to be implicit DHT+IPNI

Full context:
#9422 (comment)
@BigLep
Copy link
Contributor Author

BigLep commented Dec 7, 2022

@guseggert and @ajnavarro : what is remaining here before this is done? Is it #9475 ?

@guseggert
Copy link
Contributor

I'll defer to @lidel who is handling the config stuff. For integration of the HTTP client, I believe #9478 is the last PR.

@BigLep
Copy link
Contributor Author

BigLep commented Dec 8, 2022

2022-12-08: just waiting on #9422 to be merged (as it also includes important docs items) and then this can be resolved.

@lidel lidel closed this as completed in 70e604f Dec 8, 2022
Repository owner moved this from 🏃‍♀️ In Progress to 🎉 Done in IPFS Shipyard Team Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants