feat: remove mplex #10094
Closed
feat: remove mplex #10094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to update after our yesterday meeting, We will do that in v0.24 for 0.23 we are either gonna use Ethereum's V2 mplex or copy the old impl temporarily in an internal Kubo package. |
|
@Jorropo please take that on then. I will keep this PR open until you have that ready, since I need it to test other PRs. We can also re-use it for Kubo 0.24. Also, this actually fails if we bump Boxo because of the upgrades to |
Co-Authored-By: Jorropo <jorropo.pgm@gmail.com>
|
Closing this now. It can be revived when we actually fully remove Mplex the next release. |
|
Full removal of mplex is in #10069 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely based on #10051. Requires #10068.
Boxo was updated with ipfs/boxo#431, which updates
go-libp2p, which removed support for mplex.