Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/commands: remove 'ipfs dht' commands, except 'query' #10328

Merged
merged 2 commits into from
Feb 7, 2024
Merged

core/commands: remove 'ipfs dht' commands, except 'query' #10328

merged 2 commits into from
Feb 7, 2024

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jan 31, 2024 •
edited
Loading

Built on #10329. This addresses some notes in #10265 (comment):

  • Removes /api/v0/dht commands, except for /api/v0/dht/query

@hacdias hacdias changed the title Routing, DHT commands cleanup Cleanup of DHT and Routing Commands Jan 31, 2024
@hacdias hacdias self-assigned this Jan 31, 2024
@hacdias hacdias marked this pull request as ready for review January 31, 2024 14:32
@hacdias hacdias requested a review from a team as a code owner January 31, 2024 14:32
@hacdias
Copy link
Member Author

hacdias commented Jan 31, 2024 •
edited
Loading

This is blocked by progress in https://github.com/ipfs/js-kubo-rpc-client, which is extremely out of date. I extracted the Go RPC cleanup to #10329, which can be merged by itself.

@hacdias hacdias changed the base branch from master to routing-coreapi February 1, 2024 11:01
@hacdias hacdias changed the title Cleanup of DHT and Routing Commands core/commands: remove 'ipfs dht' commands, except 'query' Feb 1, 2024
@hacdias hacdias force-pushed the routing-coreapi branch 2 times, most recently from 9365b3a to 50caaf2 Compare February 6, 2024 10:35
@hacdias
Copy link
Member Author

hacdias commented Feb 6, 2024 •
edited
Loading

We agreed on doing a small patch in the JS client: ipfs/js-kubo-rpc-client#215 and release as a patch release, so people get this automatically.

@lidel lidel mentioned this pull request Feb 6, 2024
Merged
lidel
lidel approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that #10329 is doing the same thing we did in ipfs/js-kubo-rpc-client#215 and switch DHT to /routing backend, so lgtm.

FYI:

I've bumped js lib build a few times and it finally released:

That allowed us to restart CI job and helia-interop is green again:

Small cosmetics inline, but ok to merge (your call when @hacdias , since you also have #10329)
Thank you for cleaning this up, in the long term will reduce a lot of confusion.

docs/changelogs/v0.27.md Outdated Show resolved Hide resolved
docs/changelogs/v0.27.md Outdated Show resolved Hide resolved
@lidel lidel mentioned this pull request Feb 6, 2024
Merged
Base automatically changed from routing-coreapi to master February 7, 2024 09:47
@hacdias @lidel
Apply suggestions from code review
f17f9ef 
Co-authored-by: Marcin Rataj <lidel@lidel.org>
@hacdias hacdias mentioned this pull request Feb 7, 2024
Closed
@hacdias hacdias enabled auto-merge (squash) February 7, 2024 09:55
@hacdias hacdias merged commit 1ef8f83 into master Feb 7, 2024
14 checks passed
@hacdias hacdias deleted the routing-cleanup branch February 7, 2024 09:56
@hacdias hacdias mentioned this pull request Feb 7, 2024
Closed
8 tasks
@lidel lidel mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees

@hacdias hacdias

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacdias @lidel