feat(bitswap): allow configuring WithWantHaveReplaceSize #10512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow conguration of the bitswap server's replace WantHave with WantBlock maximum block size using the `Internal.Bitswap.ReplaceHasWithBlockMaxSize` config item. This sets the maximum size of a block in bytes up to which we will replace a want-have with a want-block. Setting a size of 0 disables this replacement and means that block sizes are not read for WantHave requests.
This was referenced Sep 14, 2024
lidel
changed the title
lidel
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Lgtm, feel free to merge after switching to boxo release or commit from boxo main with ipfs/boxo#672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configuration of the bitswap server's replace WantHave with WantBlock maximum block size using the
Internal.Bitswap.WantHaveReplaceSizeconfig item. This sets the maximum size of a block in bytes up to which we will replace a want-have with a want-block. Setting a size of 0 disables this replacement and means that block sizes are not read for WantHave requests.See ipfs/boxo#672 for more details