Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .ipfsignore and hidden files #1204

Closed
wants to merge 8 commits into from

Conversation

gatesvp
Copy link
Contributor

@gatesvp gatesvp commented May 7, 2015

Resolution for #653

@jbenet jbenet added the backlog label May 7, 2015
"path"
"strings"

"github.com/ipfs/go-ipfs/Godeps/_workspace/src/github.com/cheggaaa/pb"
context "github.com/ipfs/go-ipfs/Godeps/_workspace/src/golang.org/x/net/context"
ignore "github.com/sabhiram/go-git-ignore"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vendoring-- try running:

make vendor

from top level? (i can also vendor for you, lmk if desired)

(4/100)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously doesn't work from Windows, will setting this up on my Linux VM and going from there.

@jbenet
Copy link
Member

jbenet commented May 7, 2015

@gatesvp comments above o/ -- also looks like tests failed from lack of godeps

gatesvp added a commit to gatesvp/go-ipfs that referenced this pull request May 8, 2015
gatesvp added a commit to gatesvp/go-ipfs that referenced this pull request May 14, 2015
@gatesvp gatesvp closed this May 14, 2015
@jbenet jbenet removed the backlog label May 14, 2015
jbenet pushed a commit that referenced this pull request May 14, 2015
#1204

[ reworded to conform to commit msg guidelines ]
gatesvp added a commit to gatesvp/go-ipfs that referenced this pull request May 14, 2015
ipfs#1204

[ reworded to conform to commit msg guidelines ]
jbenet pushed a commit that referenced this pull request May 15, 2015
This commit implements support for .ipfsignore files.

- Make ipfs add ignore files by default.
- ipfs add now respects .ipfsignore files
- checks parent paths for .ipfsignore files, recursively
- respect file path separator on all OSes
- Fix OS-specific slashing without strconv
- Fix is_hidden on non-Windows
- Vendoring for .ipfsignore support

CR in
- #1204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants