Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for cat error message when ipfs init hasn't been run #1293

Merged
merged 2 commits into from
May 30, 2015
Merged

Add test for cat error message when ipfs init hasn't been run #1293

merged 2 commits into from
May 30, 2015

Conversation

rht
Copy link
Contributor

@rht rht commented May 26, 2015

@jbenet jbenet added the backlog label May 26, 2015
@rht rht force-pushed the cleanup-cat-error branch 4 times, most recently from eb5d46d to 988d937 Compare May 26, 2015 16:46
@whyrusleeping
Copy link
Member

test failure is.... iptb. i really wish i could repro that locally, but i think its a dht issue.

This all LGTM

jbenet
jbenet reviewed May 30, 2015
View reviewed changes
repo/fsrepo/fsrepo.go
@@ -52,7 +52,7 @@ type NoRepoError struct {
var _ error = NoRepoError{}

func (err NoRepoError) Error() string {
return fmt.Sprintf("no ipfs repo found in '%s'. please run: ipfs init ", err.Path)
return fmt.Sprintf("no ipfs repo found in %s. please run: ipfs init", err.Path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe let's use a newline:

"no ipfs repo found in: %s.\nplease run: ipfs init"

@jbenet
Copy link
Member

jbenet commented May 30, 2015

@rht this LGTM, two comments:

  • add newline to error message
  • rebase on master

@rht
Copy link
Contributor Author

rht commented May 30, 2015

Rebased && Add newline.

Hey what is the short-hand notation for "except for the known breakages and/or iptb, test works"?

jbenet added a commit that referenced this pull request May 30, 2015
@jbenet
Merge pull request #1293 from rht/cleanup-cat-error
ee10b41 
Add test for cat error message when `ipfs init` hasn't been run
@jbenet jbenet merged commit ee10b41 into ipfs:master May 30, 2015
@jbenet jbenet removed the backlog label May 30, 2015
@wking wking mentioned this pull request Jun 12, 2015
Closed
@rht rht deleted the cleanup-cat-error branch June 12, 2015 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rht @whyrusleeping @jbenet