Maint/fuse #1301
Merged
Maint/fuse #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whyrusleeping found some unmount issue in the sharness tests, I think. |
|
yeah, i'm really not sure whats going on here: https://github.com/ipfs/go-ipfs/blob/master/test/sharness/t0030-mount.sh#L30 |
|
although it is unrelated (i beleive) to this PR |
|
I also don't see any changes to exit/unmount behaviour in the shortlog: |
|
@cryptix these are in two different commits, which will not pass? squash? every commit must pass. |
|
I pushed the first one before I knew of the 2nd API change, they should both pass. I can squash as well and update the commit msg with the upstream changes. |
|
@cryptix +1 to squash |
fuse: Attr() now has a Context parameter and error return value
~GOPATH/src/bazil.org/fuse:master$ git shortlog 48c34fb7780b88aca1696bf865508f6703aa47f1..e4fcc9a2c7567d1c42861deebeb483315d222262
Tommi Virtanen (8):
Remove dead code
Make saveLookup take Context, return error
Make serveNode.attr take Context, return error
Make nodeAttr take Context, return error
API change: Move attribute validity time inside Attr
Set attribute validity default time in one place
API change: Attr method takes Context, returns error
Set LookupResponse validity times up front, instead of after the handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
bazilion.org/fuseto use latestNode.Attrfunction signature. (Context and errors, yey!)