Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godeps: update cheggaaa/pb to the latest version #1339

Merged
merged 1 commit into from
Jun 6, 2015
Merged

Conversation

chriscool
Copy link
Contributor

This reduces the number of race conditions found with:

make GOFLAGS=-race verbose=t deps t0090-get.sh

See #1012 (ipfs get race conditions) and #1323 (Revert "godeps: update everything to master").

License: MIT
Signed-off-by: Christian Couder chriscool@tuxfamily.org

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@jbenet jbenet added the status/in-progress In progress label Jun 6, 2015
@chriscool
Copy link
Contributor Author

One of the Travis test failed with:

expecting success: 
        test_kill_repeat_10_sec $IPFS_PID

not ok 19 - 'ipfs daemon' can be killed
#   
#           test_kill_repeat_10_sec $IPFS_PID
#       

@chriscool
Copy link
Contributor Author

Other Travis go tests failed with: No output has been received in the last ... minutes...

The circleci go tests failed with:

=== RUN TestLargeSwarm
race: limit on 8192 simultaneously alive goroutines is exceeded, dying
FAIL    github.com/ipfs/go-ipfs/exchange/bitswap    8.922s

@jbenet
Copy link
Member

jbenet commented Jun 6, 2015

@chriscool

  • i've seen that travis daemon kill problem. thoughts there?
  • are the circleci tests running -race on everything?? shouldn't
  • i'll merge this cause it's unrelated

jbenet added a commit that referenced this pull request Jun 6, 2015
Godeps: update cheggaaa/pb to the latest version
@jbenet jbenet merged commit 553960d into master Jun 6, 2015
@jbenet jbenet removed the status/in-progress In progress label Jun 6, 2015
@jbenet jbenet deleted the update-cheggaaa-pb branch June 6, 2015 23:35
@wking wking mentioned this pull request Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants