Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use github.com/chriscool/go-sleep #1341

Merged
merged 3 commits into from
Jun 7, 2015
Merged

Use github.com/chriscool/go-sleep #1341

merged 3 commits into from
Jun 7, 2015

Conversation

chriscool
Copy link
Contributor

This is because sleep cannot portably sleep for less than one second as discussed in PR #1326.

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@jbenet jbenet added the status/in-progress In progress label Jun 6, 2015
@jbenet
Copy link
Member

jbenet commented Jun 6, 2015

there seems to be a bug:

License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@chriscool
Copy link
Contributor Author

@jbenet yeah there were a copy-paste mistake and an entry in test/sharness/Makefile missing.
While at it I also improved the subject of the last 2 commits.

The failure in Travis is in a go test:

--- FAIL: TestBootstrap (5.98s)
    dht_test.go:315: connecting 30 dhts in a ring
    dht_test.go:78: dial attempt failed: misdial to <peer.ID aPUb65> through /ip4/127.0.0.1/tcp/45256 (got <peer.ID >)
08:31:50.871 CRITI   boguskey: TestBogusPrivateKey.Sign -- this better be a test! key.go:54
FAIL
FAIL    github.com/ipfs/go-ipfs/routing/dht 9.681s

And the CircleCi failure is also in a go test.

jbenet added a commit that referenced this pull request Jun 7, 2015
Use github.com/chriscool/go-sleep
@jbenet jbenet merged commit 3971607 into master Jun 7, 2015
@jbenet jbenet removed the status/in-progress In progress label Jun 7, 2015
@jbenet jbenet deleted the use-go-sleep branch June 7, 2015 10:58
@jbenet
Copy link
Member

jbenet commented Jun 7, 2015

LGTM thanks!

@wking wking mentioned this pull request Jun 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants