Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated Dockerfile to use alpine linux #1481

Merged
merged 1 commit into from
Jul 15, 2015
Merged

Migrated Dockerfile to use alpine linux #1481

merged 1 commit into from
Jul 15, 2015

Conversation

Luzifer
Copy link
Member

@Luzifer Luzifer commented Jul 15, 2015

@jbenet PTAL

TODO:

  • Check checksum for downloaded asset

@GitCop
Copy link

GitCop commented Jul 15, 2015

There were the following issues with your Pull Request

  • Commit: 6f50c70
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue


This message was auto-generated by https://gitcop.com

@jbenet jbenet added the backlog label Jul 15, 2015
@jbenet
Copy link
Member

jbenet commented Jul 15, 2015

this LGTM. rerunning tests

@jbenet
Copy link
Member

jbenet commented Jul 15, 2015

thanks @Luzifer !

@jbenet
Copy link
Member

jbenet commented Jul 15, 2015

also cc @lgierth for CR

@GitCop
Copy link

GitCop commented Jul 15, 2015

There were the following issues with your Pull Request

  • Commit: 6f50c70
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>
  • Commit: 9f34551
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue


This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Jul 15, 2015

There were the following issues with your Pull Request

  • Commit: 6f50c70
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>
  • Commit: 9f34551
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>
  • Commit: 6fb9fee
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue


This message was auto-generated by https://gitcop.com

License: MIT Signed-off-by: Knut Ahlers <knut@ahlers.me>
@GitCop
Copy link

GitCop commented Jul 15, 2015

There were the following issues with your Pull Request

  • Commit: a245a27
    • Invalid signoff. Commit message must end with License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue


This message was auto-generated by https://gitcop.com

@Luzifer Luzifer changed the title WIP: Migrated Dockerfile to use alpine linux Migrated Dockerfile to use alpine linux Jul 15, 2015
@Luzifer
Copy link
Member Author

Luzifer commented Jul 15, 2015

@jbenet PTAL again. Now with checksum checking

@ghost
Copy link

ghost commented Jul 15, 2015

I'd prefer if we build from source, for a number of reasons:

  • we don't need the shacheck script
  • we can build images from local changes or feature branches (important, imo)
  • we can strip down the size a bit more by using the musl libc

@jbenet
Copy link
Member

jbenet commented Jul 15, 2015

But then we need the go compiler, which isn't small.

+1 for building from branches.

The hash check should prob still happen (if we can get go to be reproducible).

@ghost
Copy link

ghost commented Jul 15, 2015

Anyhow, let's go with this for now 👍

My comments are not a blocker regarding that blog posting.

@jbenet
Copy link
Member

jbenet commented Jul 15, 2015

@Luzifer gitcop is complaining because you have

License: MIT Signed-off-by: Knut Ahlers <knut@ahlers.me>

it expects:

License: MIT
Signed-off-by: Knut Ahlers <knut@ahlers.me>

maybe use: https://github.com/ipfs/community/blob/master/dev/tools/hooks/setup_commit_msg_hook.sh

(doesn't matter for this, i'll merge it)


echo "Checking SHA1: ${ONLINE_SHA} == $(sha1sum ${FILENAME} | awk '{print $1}')"

echo "${ONLINE_SHA} ${FILENAME}" | sha1sum -cw
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we should use the multihash tool (it's already in the Godeps), but that can be an improvement later.

jbenet added a commit that referenced this pull request Jul 15, 2015
Migrated Dockerfile to use alpine linux
@jbenet jbenet merged commit 8668f40 into ipfs:master Jul 15, 2015
@jbenet jbenet removed the backlog label Jul 15, 2015
@jbenet
Copy link
Member

jbenet commented Jul 15, 2015

thanks @Luzifer @lgierth

@jbenet jbenet deleted the alpine branch July 15, 2015 18:44
@ghost ghost mentioned this pull request Jul 15, 2015
4 tasks
@jbenet jbenet modified the milestone: IPFS 0.3.6 Jul 28, 2015
@RX14
Copy link

RX14 commented Sep 10, 2015

Would it not be better to make the Dockerfile build from current source rather than the latest gobuilder, because then with the docker auto build you get actual latest, and I presume the docker auto builds are faster than the gobuilder builds.

@balupton
Copy link
Member

balupton commented Jan 11, 2018

this seems undone by looking at the latest master - any solutions for using go-ipfs on alpine linux docker containers?

@ghost
Copy link

ghost commented Jan 11, 2018

@balupton you'll have to build go-ipfs yourself in an Alpine container (or another way that makes sure it's linked against musl libc). We generally don't have containers or prebuilt binaries linked with musl, but we'd like to in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants