-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated Dockerfile to use alpine linux #1481
Conversation
There were the following issues with your Pull Request
Guidelines are available to help. Your feedback on GitCop is welcome on this issue This message was auto-generated by https://gitcop.com |
this LGTM. rerunning tests |
thanks @Luzifer ! |
also cc @lgierth for CR |
There were the following issues with your Pull Request
Guidelines are available to help. Your feedback on GitCop is welcome on this issue This message was auto-generated by https://gitcop.com |
There were the following issues with your Pull Request
Guidelines are available to help. Your feedback on GitCop is welcome on this issue This message was auto-generated by https://gitcop.com |
License: MIT Signed-off-by: Knut Ahlers <knut@ahlers.me>
There were the following issues with your Pull Request
Guidelines are available to help. Your feedback on GitCop is welcome on this issue This message was auto-generated by https://gitcop.com |
@jbenet PTAL again. Now with checksum checking |
I'd prefer if we build from source, for a number of reasons:
|
But then we need the go compiler, which isn't small. +1 for building from branches. The hash check should prob still happen (if we can get go to be reproducible). |
Anyhow, let's go with this for now 👍 My comments are not a blocker regarding that blog posting. |
@Luzifer gitcop is complaining because you have
it expects:
maybe use: https://github.com/ipfs/community/blob/master/dev/tools/hooks/setup_commit_msg_hook.sh (doesn't matter for this, i'll merge it) |
|
||
echo "Checking SHA1: ${ONLINE_SHA} == $(sha1sum ${FILENAME} | awk '{print $1}')" | ||
|
||
echo "${ONLINE_SHA} ${FILENAME}" | sha1sum -cw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we should use the multihash
tool (it's already in the Godeps), but that can be an improvement later.
Migrated Dockerfile to use alpine linux
Would it not be better to make the Dockerfile build from current source rather than the latest gobuilder, because then with the docker auto build you get actual latest, and I presume the docker auto builds are faster than the gobuilder builds. |
this seems undone by looking at the latest master - any solutions for using go-ipfs on alpine linux docker containers? |
@balupton you'll have to build go-ipfs yourself in an Alpine container (or another way that makes sure it's linked against musl libc). We generally don't have containers or prebuilt binaries linked with musl, but we'd like to in the future. |
@jbenet PTAL
TODO: