Some fixes to bitswap + dht #155
Conversation
|
cc @whyrusleeping lmk thoughts here. prob not fully ready yet-- will check things out with your new cmd |
| @@ -88,8 +84,16 @@ func (bs *bitswap) Block(parent context.Context, k u.Key) (*blocks.Block, error) | |||
| for iiiii := range peersToQuery { | |||
There was a problem hiding this comment.
haha, yeah. I'll fix that
jbenet
force-pushed
the
master
branch
2 times, most recently
from
cd43433 to
8f1c12e
Compare
Important bugfix. Otherwise bitswap cannot message peers the node has not connected to yet :(
Otherwise don't have the peer's target address.
(that wasn't mine :p)
important to always reread your code.
for some reason travis has more goroutines running by def.
So, it was the "which connection picked" problem. So, I implemented MultiConn, and it works now. And i also solved all sorts of ugly connection startup/teardown problems we had. Fixed most things detailed in #187 (at least for now), using my new and shiny ContextCloser. (tests on travis seem to be very time dependent. particularly things waiting for connection teardowns. seems like we'll need to just bump all timeouts by 2-3 orders of magnitude :/) |
|
@whyrusleeping pls see if it fails for you still, and if not, let's merge this. |
need to switch away from timing tests. its very annoying. Should use proper go sync, as in https://www.youtube.com/watch?v=ndmB0bj7eyw
|
5/5 runs passed for me! LGTM |
|
|
remove redundant error check
* add a flag to enable the hole punching service * chore: omitempty EnableHolePunching Co-authored-by: Marcin Rataj <lidel@lidel.org>
…pfs#155) * add a flag to enable the hole punching service * chore: omitempty EnableHolePunching Co-authored-by: Marcin Rataj <lidel@lidel.org>
…pfs#155) * add a flag to enable the hole punching service * chore: omitempty EnableHolePunching Co-authored-by: Marcin Rataj <lidel@lidel.org>
…pfs#155) * add a flag to enable the hole punching service * chore: omitempty EnableHolePunching Co-authored-by: Marcin Rataj <lidel@lidel.org>
No description provided.