-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import sub-lib of iptb so go doesnt whine about importing a binary #1644
Conversation
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
( |
interesting. ok |
tests fail |
@jbenet tests fail because i need to run |
I will take a look at fixing |
I have no subdirectories in go-sleep, so I guess I just have to vendor "go-sleep.go"? |
Well, go-sleep is already vendored so I don't think I need to do anything. |
@chriscool its vendored, but the way we keep it vendored is by having the file |
So I have to create a |
@chriscool thats kinda what I did, except i just put a |
@whyrusleeping this is to fix #1660 right? |
nvm, this doesnt work. |
This means that I don't need to change go-sleep, right? |
Ok, I just saw PR #1686 which replaces this one. Thanks @whyrusleeping ! |
This is one way (probably the easiest way) we can fix the godeps issue in go1.5
It feels kinda hacky. So i'm not sure if this is the right way, but it works
If this is the way we want to do it, @chriscool will need to do something similar for
go-sleep
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com