Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import sub-lib of iptb so go doesnt whine about importing a binary #1644

Closed
wants to merge 1 commit into from

Conversation

whyrusleeping
Copy link
Member

This is one way (probably the easiest way) we can fix the godeps issue in go1.5

It feels kinda hacky. So i'm not sure if this is the right way, but it works

If this is the way we want to do it, @chriscool will need to do something similar for go-sleep

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@jbenet jbenet added the status/in-progress In progress label Sep 3, 2015
@whyrusleeping
Copy link
Member Author

(godep save -r ./... will also need to be run once go-sleep is fixed)

@jbenet
Copy link
Member

jbenet commented Sep 4, 2015

interesting. ok

@jbenet
Copy link
Member

jbenet commented Sep 4, 2015

tests fail

@whyrusleeping
Copy link
Member Author

@jbenet tests fail because i need to run godep save -r ./... but i cant do that until go-sleep is fixed

@chriscool
Copy link
Contributor

I will take a look at fixing go-sleep.

@chriscool
Copy link
Contributor

I have no subdirectories in go-sleep, so I guess I just have to vendor "go-sleep.go"?

@chriscool
Copy link
Contributor

Well, go-sleep is already vendored so I don't think I need to do anything.

@whyrusleeping
Copy link
Member Author

@chriscool its vendored, but the way we keep it vendored is by having the file util/sadhack/godeps.go import it. Which was fine in go1.4, but with go1.5, it throws an error if you try to import a main package.

@chriscool
Copy link
Contributor

So I have to create a lib directory, put everything there and vendor that?

@whyrusleeping
Copy link
Member Author

@chriscool thats kinda what I did, except i just put a lib.go file in the lib dir with just a package header inside. Its hacky, but i'm not sure of a better way to get godeps to keep binaries around.

@jbenet
Copy link
Member

jbenet commented Sep 6, 2015

@whyrusleeping this is to fix #1660 right?

@ghost ghost mentioned this pull request Sep 8, 2015
41 tasks
@whyrusleeping
Copy link
Member Author

nvm, this doesnt work.

@jbenet jbenet removed the status/in-progress In progress label Sep 11, 2015
@whyrusleeping whyrusleeping deleted the fix/godeps-1.5 branch September 11, 2015 01:08
@chriscool
Copy link
Contributor

This means that I don't need to change go-sleep, right?

@chriscool
Copy link
Contributor

Ok, I just saw PR #1686 which replaces this one. Thanks @whyrusleeping !

@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants