first pass at a tar importer #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
feat/tar-fmt
branch
from
0de8947
to
5464020
Compare
| return nil, err | ||
| } | ||
|
|
||
| err = root.AddNodeLinkClean(h.Name, header) |
There was a problem hiding this comment.
so the root is going to get massive (thousands of links). we dont have sharding yet, so maybe this should work like the path bubble-up
|
this is fantastic |
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
@jbenet updated |
|
@whyrusleeping LGTM. maybe a roundtrip test? use |
|
sure thing! |
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
|
roundtrip test away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the importing of tar files into ipfs, provides greater dedupe than simple using 'ipfs add' on the tar file. Also adds a command to export a tar back out from the added hash
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com